Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Object validation #307

Merged
merged 6 commits into from
Dec 15, 2023
Merged

Conversation

sebastianswms
Copy link
Collaborator

Modifies the schema for jsonb and json objects because using an empty schema was not previously function for all taps (ex: tap-csv).

Closes #303

@sebastianswms sebastianswms requested a review from visch December 6, 2023 15:35
Copy link
Member

@edgarrmondragon edgarrmondragon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did some testing against target-postgres and it does seem to work as expected!

tap_postgres/client.py Outdated Show resolved Hide resolved
@sebastianswms sebastianswms requested a review from visch December 15, 2023 20:40
@visch
Copy link
Member

visch commented Dec 15, 2023

Did some testing against target-postgres and it does seem to work as expected!

Thank you :D

@visch visch merged commit 60d89a8 into MeltanoLabs:main Dec 15, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Objects not validating properly anymore
3 participants