Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using uuidv7 column for incremental load fails #519

Closed
nikzavada opened this issue Oct 20, 2024 · 5 comments
Closed

Using uuidv7 column for incremental load fails #519

nikzavada opened this issue Oct 20, 2024 · 5 comments
Assignees
Labels
bug Something isn't working Singer SDK Requires upstream Singer SDK changes

Comments

@nikzavada
Copy link

Hello everyone,

as the uuid v7 is sortable I wanted to use it as the incremental column but I got the next error:

File ".meltano/extractors/tap-postgres/venv/lib/python3.9/site-packages/singer_sdk/helpers/_state.py", line 228, in increment_state cmd_type │
if old_rk_value is None or not check_sorted or new_rk_value >= old_rk_value:
TypeError: '>=' not supported between instances of 'UUID' and 'str'

Would it be possible to fix this issue?

Thank you,
Nik

@edgarrmondragon edgarrmondragon self-assigned this Oct 24, 2024
@edgarrmondragon edgarrmondragon added the bug Something isn't working label Oct 24, 2024
@nikzavada
Copy link
Author

Hi @edgarrmondragon, Is there any ETA for fixing this issue?
As I understand we can convert the UUID to string here https://github.com/meltano/sdk/blob/main/singer_sdk/helpers/_typing.py#L40 and just compare strings. Can I take a part to push this forward?

@edgarrmondragon
Copy link
Member

edgarrmondragon commented Nov 11, 2024

@nikzavada I've logged the issue upstream (meltano/sdk#2754) and labeled it for accepting PRs. Feel free to send us a PR.

@edgarrmondragon edgarrmondragon removed their assignment Nov 11, 2024
@edgarrmondragon edgarrmondragon added the Singer SDK Requires upstream Singer SDK changes label Nov 11, 2024
@nikzavada
Copy link
Author

@nikzavada I've logged the issue upstream (meltano/sdk#2754) and labeled it for accepting PRs. Feel free to send us a PR.

@edgarrmondragon thank you! and this is the PR

@edgarrmondragon
Copy link
Member

edgarrmondragon commented Nov 11, 2024

@nikzavada this should've been fixed by v0.0.19, which will also land on PyPI in a couple of minutes. Let me know if there error is indeed gone with this release.

@edgarrmondragon edgarrmondragon self-assigned this Nov 11, 2024
@edgarrmondragon edgarrmondragon moved this to In Progress in MeltanoLabs Overview Nov 11, 2024
@nikzavada
Copy link
Author

@edgarrmondragon The error is gone! Thank you for your help!

@github-project-automation github-project-automation bot moved this from In Progress to Done in MeltanoLabs Overview Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Singer SDK Requires upstream Singer SDK changes
Projects
Archived in project
Development

No branches or pull requests

2 participants