refactor: Dropped support for Python 3.8 (#335)

Author: edgarrmondragon

.github/workflows/test_tap.yml

@@ -39,7 +39,6 @@ jobs:
         - "3.11"
         - "3.10"
         - "3.9"
-        - "3.8"
       # run the matrix jobs one after the other so they can benefit from caching
       max-parallel: 1
 

.sonarcloud.properties

@@ -1,2 +1,2 @@
-sonar.python.version=3.7, 3.8, 3.9, 3.10
+sonar.python.version=3.9, 3.10, 3.11, 3.12, 3.13
 sonar.cpd.exclusions=**/*

poetry.lock

@@ -11,7 +11,6 @@ classifiers = [
 	"Intended Audience :: Developers",
 	"License :: OSI Approved :: Apache Software License",
 	"Operating System :: OS Independent",
-	"Programming Language :: Python :: 3.8",
 	"Programming Language :: Python :: 3.9",
 	"Programming Language :: Python :: 3.10",
 	"Programming Language :: Python :: 3.11",
@@ -28,7 +27,7 @@ classifiers = [
 beautifulsoup4 = "~=4.12.0"
 nested-lookup = "~=0.2.25"
 PyJWT = "2.9.0"
-python = ">=3.8"
+python = ">=3.9"
 python-dateutil = "~=2.9"
 requests = "~=2.32.3"
 # For local SDK dev:
@@ -62,17 +61,21 @@ markers = [
 ]
 
 [tool.ruff]
-target-version = "py38"
+target-version = "py39"
 
 [tool.ruff.lint]
 ignore = []
 select = [
-	"F",   # Pyflakes
-	"E",   # pycodestyle (errors)
-	"W",   # pycodestyle (warnings)
-	"I",   # isort
-	"UP",  # pyupgrade
-	"FA",  # flake8-future-annotations
-	"SIM", # flake8-simplify
-	"RUF", # Ruff-specific rules
+	"F",   	# Pyflakes
+	"E",   	# pycodestyle (errors)
+	"W",   	# pycodestyle (warnings)
+	"I",   	# isort
+	"UP",  	# pyupgrade
+	"DTZ", 	# flake8-datetimez
+	"FA",  	# flake8-future-annotations
+	"SIM", 	# flake8-simplify
+	"TC",  	# flake8-type-checking
+	"PERF", # Perflint
+	"FURB", # refurb
+	"RUF", 	# Ruff-specific rules
 ]

pyproject.toml

@@ -8,12 +8,14 @@
 from datetime import datetime, timedelta, timezone
 from os import environ
 from random import choice, shuffle
-from typing import Any
+from typing import TYPE_CHECKING, Any
 
 import jwt
 import requests
 from singer_sdk.authenticators import APIAuthenticatorBase
-from singer_sdk.streams import RESTStream
+
+if TYPE_CHECKING:
+    from singer_sdk.streams import RESTStream
 
 
 class TokenManager:
@@ -307,7 +309,7 @@ def prepare_tokens(self) -> list[TokenManager]:
                 )
                 if app_token_manager.is_valid_token():
                     app_token_managers.append(app_token_manager)
-            except ValueError as e:
+            except ValueError as e:  # noqa: PERF203
                 self.logger.warning(
                     f"An error was thrown while preparing an app token: {e}"
                 )

tap_github/authenticator.py

@@ -7,11 +7,9 @@
 import random
 import time
 from types import FrameType
-from typing import Any, ClassVar, Iterable, cast
+from typing import TYPE_CHECKING, Any, ClassVar, cast
 from urllib.parse import parse_qs, urlparse
 
-import requests
-from backoff.types import Details
 from dateutil.parser import parse
 from nested_lookup import nested_lookup
 from singer_sdk.exceptions import FatalAPIError, RetriableAPIError
@@ -20,6 +18,12 @@
 
 from tap_github.authenticator import GitHubTokenAuthenticator
 
+if TYPE_CHECKING:
+    from collections.abc import Iterable
+
+    import requests
+    from backoff.types import Details
+
 EMPTY_REPO_ERROR_STATUS = 409
 
 

tap_github/client.py

@@ -2,12 +2,15 @@
 
 from __future__ import annotations
 
-from typing import Any, ClassVar, Iterable
+from typing import TYPE_CHECKING, Any, ClassVar
 
 from singer_sdk import typing as th  # JSON Schema typing helpers
 
 from tap_github.client import GitHubRestStream
 
+if TYPE_CHECKING:
+    from collections.abc import Iterable
+
 
 class OrganizationStream(GitHubRestStream):
     """Defines a GitHub Organization Stream.

tap_github/organization_streams.py

@@ -2,10 +2,9 @@
 
 from __future__ import annotations
 
-from typing import Any, ClassVar, Iterable
+from typing import TYPE_CHECKING, Any, ClassVar
 from urllib.parse import parse_qs, urlparse
 
-import requests
 from dateutil.parser import parse
 from singer_sdk import typing as th  # JSON Schema typing helpers
 from singer_sdk.exceptions import FatalAPIError
@@ -21,6 +20,11 @@
 )
 from tap_github.scraping import scrape_dependents, scrape_metrics
 
+if TYPE_CHECKING:
+    from collections.abc import Iterable
+
+    import requests
+
 
 class RepositoryStream(GitHubRestStream):
     """Defines 'Repository' stream."""

tap_github/repository_streams.py

@@ -9,11 +9,15 @@
 import re
 import time
 from datetime import datetime, timezone
-from typing import Any, Iterable, cast
+from typing import TYPE_CHECKING, Any, cast
 from urllib.parse import urlparse
 
 import requests
-from bs4 import NavigableString, Tag
+
+if TYPE_CHECKING:
+    from collections.abc import Iterable
+
+    from bs4 import NavigableString, Tag
 
 used_by_regex = re.compile(" {3}Used by ")
 contributors_regex = re.compile(" {3}Contributors ")
@@ -30,12 +34,7 @@ def scrape_dependents(
     # Navigate through Package toggle if present
     base_url = urlparse(response.url).hostname or "github.com"
     options = soup.find_all("a", class_="select-menu-item")
-    links = []
-    if len(options) > 0:
-        for link in options:
-            links.append(link["href"])
-    else:
-        links.append(response.url)
+    links = [link["href"] for link in options] if len(options) > 0 else [response.url]
 
     logger.debug(links)
 

tap_github/scraping.py

@@ -1,8 +1,7 @@
 from __future__ import annotations
 
 from enum import Enum
-
-from singer_sdk.streams.core import Stream
+from typing import TYPE_CHECKING
 
 from tap_github.organization_streams import (
     OrganizationStream,
@@ -52,6 +51,9 @@
 )
 from tap_github.user_streams import StarredStream, UserContributedToStream, UserStream
 
+if TYPE_CHECKING:
+    from singer_sdk.streams.core import Stream
+
 
 class Streams(Enum):
     """