Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Experimental support for filesystem interfaces via fsspec #315

Open
wants to merge 16 commits into
base: main
Choose a base branch
from

Conversation

edgarrmondragon
Copy link
Member

@edgarrmondragon edgarrmondragon commented Aug 24, 2024

Validated implementations

Local

{
  "files": [
    {
      "entity": "alphabet",
      "path": "./tap_csv/tests/data/alphabet.csv",
      "keys": ["col1"]
    }
  ]
}

GitHub

{
  "filesystem": "github",
  "github": {
    "org": "MeltanoLabs",
    "repo": "tap-csv"
  },
  "files": [
    {
      "entity": "alphabet",
      "path": "tap_csv/tests/data/alphabet.csv",
      "keys": [
        "col1"
      ]
    }
  ]
}

Dropbox

{
  "files": [
    {
      "entity": "alphabet",
      "path": "/alphabet.csv",
      "keys": [
        "col1"
      ]
    }
  ],
  "filesystem": "dropbox",
  "dropbox": {
    "token": "...."
  }
}

@edgarrmondragon edgarrmondragon force-pushed the edgarrmondragon/feat/fsspec branch 3 times, most recently from e39a403 to 003a557 Compare August 24, 2024 00:23
@edgarrmondragon edgarrmondragon force-pushed the edgarrmondragon/feat/fsspec branch from 003a557 to 63e49be Compare August 24, 2024 00:28
@edgarrmondragon edgarrmondragon changed the title feat: Support filesystem interfaces feat: Support filesystem interfaces via fsspec Aug 24, 2024
@edgarrmondragon edgarrmondragon marked this pull request as ready for review September 5, 2024 03:04
@edgarrmondragon edgarrmondragon force-pushed the edgarrmondragon/feat/fsspec branch from e8a204c to acd9733 Compare September 5, 2024 03:14
@edgarrmondragon edgarrmondragon force-pushed the edgarrmondragon/feat/fsspec branch from dab9112 to ed7e6e9 Compare September 6, 2024 02:20
@edgarrmondragon edgarrmondragon force-pushed the edgarrmondragon/feat/fsspec branch from ed7e6e9 to 09d3256 Compare September 6, 2024 02:24
Copy link

sonarcloud bot commented Sep 6, 2024

@edgarrmondragon edgarrmondragon changed the title feat: Support filesystem interfaces via fsspec refactor: Experimental support for filesystem interfaces via fsspec Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

1 participant