issue:3563885:UFM Enterprise network reports #123
Conversation
…d event collection classes) issue:3572589: parse events logs files and create events list
| # | ||
| # This software product is governed by the End User License Agreement | ||
| # provided with the software product. | ||
| # @author: Anan Al-Aghbar |
There was a problem hiding this comment.
change to author in all files
| if fname.endswith(".gz"): | ||
| return gzip.open(fname, mode, encoding='utf8') | ||
| else: | ||
| return open(fname, mode) |
There was a problem hiding this comment.
from where you imported this function? it seems you forget the import statement
There was a problem hiding this comment.
The open() function is a built-in function that is part of the core Python language, so you do not need to import it
| @@ -0,0 +1,17 @@ | |||
| class Event: | |||
+ fix author name + handel exception in openEventFile function
|
|
||
| LABEL maintainer="[email protected]" | ||
|
|
||
| ARG PLUGIN_NAME |
There was a problem hiding this comment.
value for plugin name?
| out_dir=$4 | ||
| random_hash=$5 | ||
| keep_image=$6 | ||
| prefix="mellanox" |
There was a problem hiding this comment.
yes, all other plugins use mellanox as prefix
| @@ -65,12 +74,14 @@ def parse_event_log_files(self): | |||
| files.append(EventsConstants.EVENT_LOG) | |||
| for file in files: | |||
| fname = os.path.join(EventsConstants.EVENT_LOGS_DIRECTORY, file) | |||
| Logger.log_message(f"Parsing file {fname}", LOG_LEVELS.INFO) | |||
There was a problem hiding this comment.
If file not exists this message is incorrect. Message should be moved under the if, but need to mention list of files you are going to parse.
| self.last_position = self._get_last_position() | ||
| self.event_mgr = EventsHistoryMgr.getInstance() | ||
|
|
||
| def onChange(self, event): |
There was a problem hiding this comment.
How will you get last position if file was replaced by logrotate?
There was a problem hiding this comment.
need to be handled two aspects:
- Possibility of rotate of log files by logrotate - so you will need to take info from both old and new files.
- Aging of collected data - you just create new events and keep them in memory - so memory utilization will grow all the time. Need to clean collected events or to compress them.
|
|
||
| RUN apt-get update && apt-get -y install supervisor python3.9 python3-pip vim curl sudo | ||
|
|
||
| RUN python3.9 -m pip install -r ${BASE_PATH}/${SRC_BASE_DIR}/src/${PLUGIN_NAME}/requirements.txt |
There was a problem hiding this comment.
why not python3 (which is usually symlink to python3.x available)
|
|
||
| [program:events_history_service] | ||
| directory=/opt/ufm/ufm_plugin_events_history | ||
| command=python3.9 /opt/ufm/ufm_plugin_events_history/events_history_plugin/src/events_history_plugin/app.py |
…k to python3.x available
What
This plugin will assist users in monitoring events related to changes in the Fabric Topology, particularly in the context of a large fabric.
This plugin will monitor the event.log and store any new events linked to topology changes. These events will be accessible through a REST API, which will allow specifying the event type and desired time interval.
UFM has the following events linked to topology changes:
For more information please find HLD
Why ?
To assist users in monitoring events related to changes in the Fabric Topology, particularly in the context of a large fabric.
Testing ?
CI tests (not implemented yet)
Special triggers
Use the following phrases as comments to trigger different runs
bot:retestrerun CIbot:upgraderun additional update tests