Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move options to separate types #31

Open
chucker opened this issue May 27, 2020 · 0 comments
Open

Move options to separate types #31

chucker opened this issue May 27, 2020 · 0 comments

Comments

@chucker
Copy link
Contributor

chucker commented May 27, 2020

The Map class risks gaining a lot of properties, which seems a bit unwieldy to me.

Leaflet itself has an Options type, e.g. map.options.zoomDelta rather than map.zoomDelta directly. Moreover, its documentation categorizes those options: control, interaction, etc.

Maybe we should follow suit and create separate types LeafletControlOptions, LeafletStateOptions, etc.

Then the user could do:

_map.ControlOptions.ZoomControl = true;
_map.StateOptions = new LeafletStateOptions { MinZoom = 5, MaxZoom = 13 };
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant