#29, #30, 32 Updates to map properties, fixed memory leak. #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…leak. Mehigh17#29 Enables the Center and Zoom properties to set these properties on the map in the background. Mehigh17#30 Adds a Bounds property to the map that is automatically kept up to date with the map bounds. Mehigh17#32 Fixes a memory leak related to creating layers.
This was
linked to
issues
Jun 6, 2020
|
Thanks for the contribution, could you split the contribution in three commits? I think one commit per issue in this case should be enough. |
Mehigh17
requested changes
Jun 6, 2020
|
I can break this up into multiple PRs. I'll close this one when I do that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#29 Enables the Center and Zoom properties to set these properties on the map in the background.
#30 Adds a Bounds property to the map that is automatically kept up to date with the map bounds.
#32 Fixes a memory leak related to creating layers.
If you don't think one of these issues should be merged in here, let me know and I can remove them from this PR.