Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

165 front task test login part e2e test #167

Open
wants to merge 7 commits into
base: develop
Choose a base branch
from

Conversation

ejinn1
Copy link
Contributor

@ejinn1 ejinn1 commented Oct 15, 2024

๐Ÿ’กย ๋ณ€๊ฒฝ์‚ฌํ•ญ & ์ด์Šˆ

์ „์—ญ ๋กœ๊ทธ์ธ ์„ค์ •, ๋กœ๊ทธ์ธ/ํšŒ์›๊ฐ€์ž… ํ…Œ์ŠคํŠธ ์ฝ”๋“œ ์ž‘์„ฑ

โœ๏ธย ๊ด€๋ จ ์„ค๋ช…

์ „์—ญ ๋กœ๊ทธ์ธ ์„ค์ •

global-setup.ts๋กœ ์ „์—ญ์œผ๋กœ ๋กœ๊ทธ์ธ์„ ์ง„ํ–‰ํ–ˆ์Šต๋‹ˆ๋‹ค.
email: [email protected]
password: test1234@

playwright/store/auth.json ์— ๋ฐ์ดํ„ฐ ์ €์žฅ๋˜๋„๋ก ํ•˜์˜€์Šต๋‹ˆ๋‹ค.

๋กœ๊ทธ์ธ ํ…Œ์ŠคํŠธ

  1. ์˜จ๋ณด๋”ฉ ๋ฏธ์™„๋ฃŒ ์œ ์ €๊ฐ€ ๋กœ๊ทธ์ธ ํ–ˆ์„ ๋•Œ /walk-through ํŽ˜์ด์ง€๋กœ ์ด๋™ํ•˜๋Š”์ง€ ํ…Œ์ŠคํŠธ
  2. ์˜จ๋ณด๋”ฉ ์™„๋ฃŒ ์œ ์ €๊ฐ€ ๋กœ๊ทธ์ธ ํ–ˆ์„ ๋•Œ /study-room/list ํŽ˜์ด์ง€๋กœ ์ด๋™ํ•˜๋Š”์ง€ ํ…Œ์ŠคํŠธ
  3. ํšŒ์›๊ฐ€์ž…์„ ํ•˜์ง€ ์•Š์€ ์œ ์ €๊ฐ€ ๋กœ๊ทธ์ธ ํ–ˆ์„ ๋•Œ ์กด์žฌํ•˜์ง€ ์•Š๋Š” ์‚ฌ์šฉ์ž์ž…๋‹ˆ๋‹ค ํ† ์ŠคํŠธ ๋ฉ”์‹œ์ง€ ํ™•์ธ ํ…Œ์ŠคํŠธ
  4. ํšŒ์›๊ฐ€์ž… ๋˜์–ด์žˆ๋Š” ์œ ์ €๊ฐ€ ๋น„๋ฐ€๋ฒˆํ˜ธ๋ฅผ ํ‹€๋ ธ์„ ๋•Œ ๋น„๋ฐ€๋ฒˆํ˜ธ๊ฐ€ ์ž˜๋ชป๋˜์—ˆ์Šต๋‹ˆ๋‹ค ํ† ์ŠคํŠธ ๋ฉ”์‹œ์ง€ ํ™•์ธ ํ…Œ์ŠคํŠธ

ํšŒ์›๊ฐ€์ž… ํ…Œ์ŠคํŠธ

  1. ๋กœ๊ทธ์ธ ํŽ˜์ด์ง€์—์„œ ํšŒ์›๊ฐ€์ž…ํ•˜๊ธฐ ๋ฒ„ํŠผ ๋ˆŒ๋ €์„ ๋•Œ ํšŒ์›๊ฐ€์ž… ํŽ˜์ด์ง€๋กœ ์ด๋™ํ•˜๋Š”์ง€ ํ…Œ์ŠคํŠธ
  2. ์˜ฌ๋ฐ”๋ฅธ ์ž…๋ ฅ๊ฐ’์œผ๋กœ ํšŒ์›๊ฐ€์ž… ๋˜๋Š” ์ง€ ํ…Œ์ŠคํŠธ
  3. ์ž˜๋ชป๋œ ์ด๋ฉ”์ผ ์ž…๋ ฅ ์‹œ ํ† ์ŠคํŠธ ๋ฉ”์‹œ์ง€ ํ™•์ธ ํ…Œ์ŠคํŠธ
  4. ์ž˜๋ชป๋œ ๋น„๋ฐ€๋ฒˆํ˜ธ ์ž…๋ ฅ ์‹œ ํ† ์ŠคํŠธ ๋ฉ”์‹œ์ง€ ํ™•์ธ ํ…Œ์ŠคํŠธ
  5. ์ž˜๋ชป๋œ ๋น„๋ฐ€๋ฒˆํ˜ธ ํ™•์ธ ์ž…๋ ฅ ์‹œ ํ† ์ŠคํŠธ ๋ฉ”์‹œ์ง€ ํ™•์ธ ํ…Œ์ŠคํŠธ
  6. ์ด๋ฉ”์ผ ์ค‘๋ณต ์‹œ ํ† ์ŠคํŠธ ๋ฉ”์‹œ์ง€ ํ™•์ธ ํ…Œ์ŠคํŠธ

โญ๏ธ Review point

์ „์—ญ ๋กœ๊ทธ์ธ์—์„œ ๋ฌธ์ œ๊ฐ€ ์žˆ๊ฑฐ๋‚˜ ํ…Œ์ŠคํŠธ ์ฝ”๋“œ์—์„œ ๋ฌธ์ œ๊ฐ€ ์žˆ์œผ๋ฉด ๋งํ•ด์ฃผ์„ธ์—ฌ

๐Ÿ“ทย Demo

image image

@ejinn1 ejinn1 added the enhancement New feature or request label Oct 15, 2024
@ejinn1 ejinn1 self-assigned this Oct 15, 2024
@ejinn1 ejinn1 linked an issue Oct 15, 2024 that may be closed by this pull request
3 tasks
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

๊ผญ ๋ฃจํŠธ์— ์žˆ์–ด์•ผ ํ•˜๋Š”๊ฒŒ ์•„๋‹ˆ๋ฉด e2e ๋””๋ ‰ํ† ๋ฆฌ๋กœ ์˜ฎ๊ธฐ๋Š”๊ฒŒ ์ข‹์„ ๊ฑฐ ๊ฐ™์•„์š”

@@ -1,8 +1,10 @@
import { defineConfig, devices } from "@playwright/test";

export default defineConfig({
globalSetup: require.resolve("./global-setup.ts"),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

์˜ฎ๊ธฐ๊ฒŒ ๋˜๋ฉด ์—ฌ๊ธฐ๋„ ์ˆ˜์ •ํ•˜๊ณ  ์ •์ƒ์ ์œผ๋กœ ๋Œ์•„๊ฐ€๋Š”์ง€ ํ…Œ์ŠคํŠธ ๋ถ€ํƒ๋“œ๋ ค์š”

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

แ„‰แ…ณแ„แ…ณแ„…แ…ตแ†ซแ„‰แ…ฃแ†บ 2024-10-15 แ„‹แ…ฉแ„’แ…ฎ 7 07 28

e2e:ui๋กœ ํ…Œ์ŠคํŠธ์‹œ ์ €๋งŒ ์ด๋ฉ”์ผ ๊ฒ€์‚ฌ ๊ด€๋ จ์—์„œ ์‹คํŒจํ•˜๋Š”๊ฑธ๊นŒ์š”?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

๋ช‡๋ฒˆ ๋Œ๋ ค๋ณด๋‹ˆ๊นŒ ์•„๋งˆ ํ† ์ŠคํŠธ ๋ฉ”์‹œ์ง€ ๋œจ๋Š” ์ž‘์—…์—์„œ ์ง€์—ฐ ์‹œ๊ฐ„์ด ์žˆ์–ด์„œ ์‹คํŒจํ•˜๋Š” ๊ฒฝ์šฐ๊ฐ€ ์žˆ๊ณ  ์„ฑ๊ณตํ•˜๋Š” ๊ฒฝ์šฐ๊ฐ€ ์žˆ๋Š”๊ฑฐ ๊ฐ™๋„ค์š”. ๊ฐœ์„ ํ•  ์ˆ˜ ์žˆ์œผ๋ฉด ๊ฐœ์„ ํ•˜๊ณ  ์•„๋‹ˆ๋ฉด ๊ทธ๋ƒฅ ๋„˜์–ด๊ฐ€๋„ ๋  ๊ฑฐ ๊ฐ™์•„์š”


import { ERROR_MESSAGE } from "@/constants/error";

test.use({ storageState: { cookies: [], origins: [] } });
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

global-setup์„ ํ†ตํ•ด ์ž๋™ ๋กœ๊ทธ์ธ์„ ์‹œ์ผœ์ฃผ๋Š”๊ฑด๋ฐ ์—ฌ๊ธฐ์„  ๋น„๋กœ๊ทธ์ธ ์ƒํƒœ๊ฐ€ ํ•„์š”ํ•˜๊ธฐ ๋•Œ๋ฌธ์— storage๋ฅผ ์ด๋ ‡๊ฒŒ ์ดˆ๊ธฐํ™” ์‹œ์ผœ์ฃผ๋Š” ์ฝ”๋“œ๊ฐ€ ์ œ๋Œ€๋กœ ์ดํ•ดํ•œ๊ฒŒ ๋งž์„๊นŒ์š”?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FRONT-TASK] Test Login part e2e test
2 participants