From 3ac8d3515e726d4b4732434d132b424edb688f75 Mon Sep 17 00:00:00 2001 From: Boubaker Khanfir Date: Sun, 10 Dec 2023 09:32:11 +0100 Subject: [PATCH] fix: Delete useless Mocked methods - MEED-1580 - Meeds-io/meeds#1428 (#446) This change will delete flag from Mocked Test classes to not have a compilation error when deleting or modifying a fake method implementation from IdentityManager and SpaceService. In addition, this will cleanup useless methods implemented in Mocked Social Classes. --- .../kudos/test/mock/IdentityManagerMock.java | 87 ------------------- .../kudos/test/mock/SpaceServiceMock.java | 17 ---- 2 files changed, 104 deletions(-) diff --git a/kudos-services/src/test/java/org/exoplatform/kudos/test/mock/IdentityManagerMock.java b/kudos-services/src/test/java/org/exoplatform/kudos/test/mock/IdentityManagerMock.java index a56ddc9a3..1538307c2 100644 --- a/kudos-services/src/test/java/org/exoplatform/kudos/test/mock/IdentityManagerMock.java +++ b/kudos-services/src/test/java/org/exoplatform/kudos/test/mock/IdentityManagerMock.java @@ -54,7 +54,6 @@ public IdentityManagerMock() { } } - @Override public Identity getOrCreateIdentity(String providerId, String remoteId, boolean isProfileLoaded) { return identities.stream() .filter(identity -> StringUtils.equals(identity.getProviderId(), providerId) @@ -63,7 +62,6 @@ public Identity getOrCreateIdentity(String providerId, String remoteId, boolean .orElse(null); } - @Override public Identity getIdentity(String identityId, boolean isProfileLoaded) { return identities.stream() .filter(identity -> StringUtils.equals(identity.getId(), identityId)) @@ -71,77 +69,62 @@ public Identity getIdentity(String identityId, boolean isProfileLoaded) { .orElse(null); } - @Override public void registerIdentityProviders(IdentityProviderPlugin plugin) { // NOOP } - @Override public void addProfileListener(ProfileListenerPlugin plugin) { // NOOP } - @Override public Identity getIdentity(String providerId, String remoteId, boolean loadProfile) { return getOrCreateIdentity(providerId, remoteId, loadProfile); } - @Override public boolean identityExisted(String providerId, String remoteId) { return getOrCreateIdentity(providerId, remoteId, true) != null; } - @Override public Identity getIdentity(String id) { return getIdentity(id, true); } - @Override public Identity getOrCreateIdentity(String providerId, String remoteId) { return getOrCreateIdentity(providerId, remoteId, true); } - @Override public Identity updateIdentity(Identity identity) { return identity; } - @Override public List getLastIdentities(int limit) { throw new UnsupportedOperationException(); } - @Override public void deleteIdentity(Identity identity) { throw new UnsupportedOperationException(); } - @Override public void hardDeleteIdentity(Identity identity) { throw new UnsupportedOperationException(); } - @Override public ListAccess getConnectionsWithListAccess(Identity identity) { throw new UnsupportedOperationException(); } - @Override public Profile getProfile(Identity identity) { return identity.getProfile(); } - @Override public InputStream getAvatarInputStream(Identity identity) throws IOException { throw new UnsupportedOperationException(); } - @Override public InputStream getBannerInputStream(Identity identity) throws IOException { throw new UnsupportedOperationException(); } - @Override public void updateProfile(Profile specificProfile) { List list = new ArrayList<>(); if (specificProfile.getProperty(Profile.FIRST_NAME) != null || specificProfile.getProperty(Profile.POSITION) != null ) { @@ -155,19 +138,16 @@ public void updateProfile(Profile specificProfile) { } } - @Override public ListAccess getIdentitiesByProfileFilter(String providerId, ProfileFilter profileFilter, boolean isProfileLoaded) { throw new UnsupportedOperationException(); } - @Override public ListAccess getIdentitiesForUnifiedSearch(String providerId, ProfileFilter profileFilter) { throw new UnsupportedOperationException(); } - @Override public ListAccess getSpaceIdentityByProfileFilter(Space space, ProfileFilter profileFilter, Type type, @@ -175,32 +155,26 @@ public ListAccess getSpaceIdentityByProfileFilter(Space space, throw new UnsupportedOperationException(); } - @Override public void addIdentityProvider(IdentityProvider identityProvider) { throw new UnsupportedOperationException(); } - @Override public void removeIdentityProvider(IdentityProvider identityProvider) { throw new UnsupportedOperationException(); } - @Override public void registerProfileListener(ProfileListenerPlugin profileListenerPlugin) { profileLifeCycle.addListener(profileListenerPlugin); } - @Override public void processEnabledIdentity(String remoteId, boolean isEnable) { throw new UnsupportedOperationException(); } - @Override public List getIdentitiesByProfileFilter(String providerId, ProfileFilter profileFilter) throws Exception { throw new UnsupportedOperationException(); } - @Override public List getIdentitiesByProfileFilter(String providerId, ProfileFilter profileFilter, long offset, @@ -208,22 +182,18 @@ public List getIdentitiesByProfileFilter(String providerId, throw new UnsupportedOperationException(); } - @Override public List getIdentitiesByProfileFilter(ProfileFilter profileFilter) throws Exception { throw new UnsupportedOperationException(); } - @Override public List getIdentitiesByProfileFilter(ProfileFilter profileFilter, long offset, long limit) throws Exception { throw new UnsupportedOperationException(); } - @Override public List getIdentitiesFilterByAlphaBet(String providerId, ProfileFilter profileFilter) throws Exception { throw new UnsupportedOperationException(); } - @Override public List getIdentitiesFilterByAlphaBet(String providerId, ProfileFilter profileFilter, long offset, @@ -231,87 +201,30 @@ public List getIdentitiesFilterByAlphaBet(String providerId, throw new UnsupportedOperationException(); } - @Override public List getIdentitiesFilterByAlphaBet(ProfileFilter profileFilter) throws Exception { throw new UnsupportedOperationException(); } - @Override public long getIdentitiesCount(String providerId) { throw new UnsupportedOperationException(); } - @Override - public void saveIdentity(Identity identity) { - throw new UnsupportedOperationException(); - } - - @Override - public void saveProfile(Profile profile) { - throw new UnsupportedOperationException(); - } - - @Override - public void addOrModifyProfileProperties(Profile profile) throws Exception { - throw new UnsupportedOperationException(); - } - - @Override - public void updateAvatar(Profile p) { - throw new UnsupportedOperationException(); - } - - @Override - public void updateBasicInfo(Profile p) throws Exception { - throw new UnsupportedOperationException(); - } - - @Override - public void updateContactSection(Profile p) throws Exception { - throw new UnsupportedOperationException(); - } - - @Override - public void updateExperienceSection(Profile p) throws Exception { - throw new UnsupportedOperationException(); - } - - @Override - public void updateHeaderSection(Profile p) throws Exception { - throw new UnsupportedOperationException(); - } - - @Override - public List getIdentities(String providerId) throws Exception { - throw new UnsupportedOperationException(); - } - - @Override - public List getIdentities(String providerId, boolean loadProfile) throws Exception { - throw new UnsupportedOperationException(); - } - - @Override public List getConnections(Identity ownerIdentity) throws Exception { throw new UnsupportedOperationException(); } - @Override public IdentityStorage getIdentityStorage() { throw new UnsupportedOperationException(); } - @Override public IdentityStorage getStorage() { throw new UnsupportedOperationException(); } - @Override public void registerProfileListener(ProfileListener listener) { throw new UnsupportedOperationException(); } - @Override public void unregisterProfileListener(ProfileListener listener) { throw new UnsupportedOperationException(); } diff --git a/kudos-services/src/test/java/org/exoplatform/kudos/test/mock/SpaceServiceMock.java b/kudos-services/src/test/java/org/exoplatform/kudos/test/mock/SpaceServiceMock.java index 8806fcf68..9f80833bf 100644 --- a/kudos-services/src/test/java/org/exoplatform/kudos/test/mock/SpaceServiceMock.java +++ b/kudos-services/src/test/java/org/exoplatform/kudos/test/mock/SpaceServiceMock.java @@ -232,11 +232,6 @@ public Space getSpaceByName(String spaceName) throws SpaceException { } - public List getSpacesByFirstCharacterOfName(String firstCharacterOfName) throws SpaceException { - throw new UnsupportedOperationException(); - - } - public List getSpacesBySearchCondition(String condition) throws Exception { throw new UnsupportedOperationException(); @@ -573,16 +568,4 @@ public boolean isSuperManager(String userId) { return false; } - public List getSuperManagersMemberships() { - throw new UnsupportedOperationException(); - } - - public void addSuperManagersMembership(String permissionExpression) { - throw new UnsupportedOperationException(); - } - - public void removeSuperManagersMembership(String permissionExpression) { - throw new UnsupportedOperationException(); - } - }