copilot code review

Author: marythought

extensions/bridge/protocols/bridge_patient_sync.py

@@ -18,8 +18,8 @@ class BridgePatientSync(BaseProtocol):
         EventType.Name(EventType.PATIENT_UPDATED),
         EventType.Name(EventType.PATIENT_CONTACT_POINT_CREATED),
         EventType.Name(EventType.PATIENT_CONTACT_POINT_UPDATED),
-        # will need to export PatientAddress as a standalone data model to support these
         # leaving as a TODO for now
+        # will need to export PatientAddress as a standalone data model to support these
         # EventType.Name(EventType.PATIENT_ADDRESS_CREATED),
         # EventType.Name(EventType.PATIENT_ADDRESS_UPDATED),
     ]
@@ -49,21 +49,22 @@ def bridge_patient_metadata(self):
 
         return metadata
 
-    def set_patient_id(self):
+    def get_patient_id(self):
         if self.event.type in [EventType.PATIENT_CREATED, EventType.PATIENT_UPDATED]:
             return self.target
         elif self.event.type in [EventType.PATIENT_CONTACT_POINT_CREATED, EventType.PATIENT_CONTACT_POINT_UPDATED]:
             contact_point_id = self.target
-            contact_point = PatientContactPoint.objects.get(id=contact_point_id)
-            return contact_point.patient.id
+            if not hasattr(self, '_cached_contact_point') or self._cached_contact_point.id != contact_point_id:
+                self._cached_contact_point = PatientContactPoint.objects.get(id=contact_point_id)
+            return self._cached_contact_point.patient.id
         # elif self.event.type in [EventType.PATIENT_ADDRESS_CREATED, EventType.PATIENT_ADDRESS_UPDATED]:
         #     address_id = self.target
         #     address = PatientAddress.objects.get(id=address_id)
         #     return address.patient.id
 
     def compute(self):
         event_type = self.event.type
-        canvas_patient_id = self.set_patient_id()
+        canvas_patient_id = self.get_patient_id()
         contact_point_id = self.target if event_type in [EventType.PATIENT_CONTACT_POINT_CREATED, EventType.PATIENT_CONTACT_POINT_UPDATED] else None
 
         log.info(f'>>> BridgePatientSync.compute {EventType.Name(event_type)} for {canvas_patient_id}')
@@ -85,19 +86,19 @@ def compute(self):
 
         # Get a reference to the target patient
         canvas_patient = Patient.objects.get(id=canvas_patient_id)
-        contact_point = PatientContactPoint.objects.get(id=contact_point_id) if contact_point_id else None
+        contact_point = self._cached_contact_point if contact_point_id else None
 
         # Generate the payload for creating or updating the patient in Bridge
         # At the moment this is just sending a contact point (as telecom) if it is present via the event,
         # regardless of the event type (create or update)
-        # And since ContactPoint is refered to elsewhere as 'telecom' I'm assuming it is NOT an email...
+        # And since ContactPoint is referred to elsewhere as 'telecom' I'm assuming it is NOT an email...
         # TODO: Pass email and address here
         bridge_payload = {
             'externalId': canvas_patient.id,
             'firstName': canvas_patient.first_name,
             'lastName': canvas_patient.last_name,
             'dateOfBirth': canvas_patient.birth_date.isoformat(),
-            'telecom': [contact_point] if contact_point else None,
+            'telecom': contact_point if contact_point else None,
         }
 
         if event_type == EventType.PATIENT_CREATED:
@@ -185,7 +186,7 @@ def post(self) -> list[Response | Effect]:
             ]
 
         patient = Patient.objects.create(
-            first_name=json_body.get("firstName"),
+            first_name=json_body.get('firstName'),
             last_name=json_body.get('lastName'),
             birth_date=json_body.get('dateOfBirth'),
         )