-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Missing Margin Entity #41
Comments
|
|
Vertical, Audience Segment and Supply Source were added by #48 |
the campaign/:id/margins endpoint still returns the legacy xml->json converted format: "prop": [
{
"value": "123456",
"name": "campaign_id"
},
{
"value": "2017-01-19T00:00:00",
"name": "margin_date"
},
{
"value": "85.0000",
"name": "margin_pct"
},
{
"value": "2017-01-25T00:43:26",
"name": "created_on"
},
{
"value": "2017-01-25T00:43:26",
"name": "updated_on"
}
],
"name": "campaign Margin 2017-01-19",
"id": 1542715,
"type": "campaign_margins_calc"
} we'll need this to be consistent with the rest of the json responses before we can add support. |
Related to CAW-3810 (internal) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
A todo of missing entities in SDK
SupplySourceVendorContractVendorDomainVendorPixelVendorPixelDomainVerticalThe text was updated successfully, but these errors were encountered: