Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing Margin Entity #41

Open
FodT opened this issue Aug 20, 2015 · 5 comments
Open

Missing Margin Entity #41

FodT opened this issue Aug 20, 2015 · 5 comments

Comments

@FodT
Copy link
Contributor

FodT commented Aug 20, 2015

A todo of missing entities in SDK

  • Margin (campaign_margin_calc)
  • SupplySource
  • VendorContract
  • VendorDomain
  • VendorPixel
  • VendorPixelDomain
  • Vertical
@pswaminathan
Copy link
Contributor

  • Audience segments

@pswaminathan
Copy link
Contributor

  • Margin (campaign_margin_calc)

@FodT
Copy link
Contributor Author

FodT commented Jan 26, 2016

Vertical, Audience Segment and Supply Source were added by #48

@fsargent fsargent changed the title Missing entities Missing Margin Entity Jan 6, 2017
@FodT
Copy link
Contributor Author

FodT commented Jan 25, 2017

the campaign/:id/margins endpoint still returns the legacy xml->json converted format:

      "prop": [
        {
          "value": "123456",
          "name": "campaign_id"
        },
        {
          "value": "2017-01-19T00:00:00",
          "name": "margin_date"
        },
        {
          "value": "85.0000",
          "name": "margin_pct"
        },
        {
          "value": "2017-01-25T00:43:26",
          "name": "created_on"
        },
        {
          "value": "2017-01-25T00:43:26",
          "name": "updated_on"
        }
      ],
      "name": "campaign Margin 2017-01-19",
      "id": 1542715,
      "type": "campaign_margins_calc"
    }

we'll need this to be consistent with the rest of the json responses before we can add support.

@fsargent
Copy link
Contributor

Related to CAW-3810 (internal)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants