New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Interpretations don't handle empty lists well #2

Open

MaxwellBo opened this issue Feb 27, 2018 · 0 comments

Labels

good first issue help wanted

Owner

MaxwellBo commented Feb 27, 2018 •

edited

Loading

Given

      case typeBounds: Type.Bounds => {
        val hi = typeBounds.hi.map(x => f"upper bound ${x.visit}").getOrElse("")
        val lo = typeBounds.hi.map(x => f"lower bound ${x.visit}").getOrElse("")

        f"$hi $lo"
      }

and a typeBounds with both an empty hi and an empty lo. The interpretation will be

" " rather than what we want, "".

Furthermore, there should be a grammatical connective if both are present.

e.g. "lower bound <bound> and upper bound <bound>"

The text was updated successfully, but these errors were encountered:

MaxwellBo added help wanted good first issue labels

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment