Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display already added parameter types in new "Add Parameter" window as disabled #361

Open
ghramsey opened this issue Apr 12, 2024 · 2 comments
Labels
enhancement Something which will improve the user experience. [TOOL] Script Editor This issue applies to the script editor within OpenCAGE.

Comments

@ghramsey
Copy link
Sponsor

ghramsey commented Apr 12, 2024

In the new add paramter window ENUM data types are not listed.

This is a CMD_GoTo entity and in this instance the Move_Type which is an ENUM is not there,

image
image

I did a little digging to other entities such as doors and those too are missing ENUM data types from add parameters list.

edit OH. also tried searching the list for move in case it just was not listed. It doesn't show in search either. end edit

@MattFiler
Copy link
Owner

MattFiler commented Apr 12, 2024

Parameters that are already applied to the entity will not show up in that list (as you can't add the same parameter twice). Just checked a CMD_GoTo with no parameters added and the move_type enum parameter does correctly show in the list.

image

So while this isn't a bug, perhaps I should change the UI to better communicate that some options are omitted?

@MattFiler MattFiler added enhancement Something which will improve the user experience. [TOOL] Script Editor This issue applies to the script editor within OpenCAGE. labels Apr 12, 2024
@MattFiler MattFiler changed the title ENUM types missing from add parameter list Display already added parameter types in new "Add Parameter" window as disabled Apr 12, 2024
@ghramsey
Copy link
Sponsor Author

Yeah. I just caught what you did there while expermenting with a new cmd_goto also.
The list box is more efficient to only show parameters which are available for use.

And what you say makes sense. Show it as disabled where appropriate.
I like the list box though in this more compact form too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Something which will improve the user experience. [TOOL] Script Editor This issue applies to the script editor within OpenCAGE.
Projects
None yet
Development

No branches or pull requests

2 participants