Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding social and permission level discovery #736

Conversation

tegefaulkes
Copy link
Contributor

@tegefaulkes tegefaulkes commented Jun 7, 2024

Description

This PR contains work for adding social and permission level discovery to the discovery domain.

Issues Fixed

Tasks

  • 1. Implement the ability to trust and give permissions to nodes without discovering them first.
  • 2. Implement some way to list all social links for a provider. these need to include metadata such as existing claims and some useful information such as name, email and the like.
  • 3. Implement an iterator for listing trust links
  • 4. Implement an iterator for listing permission links. If permissions require trust then it might not be needed.
  • 5. Discovery should trigger on start up and use existing know vertices as the starting point.
  • 6. Implement priority queue when processing these social and permission links.

Final checklist

  • Domain specific tests
  • Full tests
  • Updated inline-comment documentation
  • Lint fixed
  • Squash and rebased
  • Sanity check the final build

@tegefaulkes tegefaulkes self-assigned this Jun 7, 2024
Copy link

linear bot commented Jun 7, 2024

@tegefaulkes
Copy link
Contributor Author

I can easily change the check in setGestaltAction so that we don't need a pre-discovered node to set a permission for it. The act of setting the action will add the node to the gestalt graph.

However, an identity can't have an action associated with it in the ACL. The permission is applied to a node it's linked to. So to be able to trust a gestalt from an identity, the identity will need to be discovered first. OR we can expand the ACL to support identities as well.

It shouldn't be too hard to add identities to the ACL, they would only exist to placeholder permissions to be linked with the gestalt when links are found.

…lready be in the `GestaltGraph` now

[ci skip]
@CMCDragonkai
Copy link
Member

Permissions only apply to nodes for a reason. Identities only exist in the context of gestalt graph. You're supposed to go from identity to node, only then would it even matter. Everytime you discover an identity if you don't have a corresponding node, there's no point in adding a permission to it... unless we expect to add permissions to identities even when they have no node associated. That could be an interesting away of doing "optimistic sharing".

@tegefaulkes
Copy link
Contributor Author

I'm mothballing this PR for now since our focus has shifted. It isn't currently worked on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants