Update Nodes domain to used timedCancellable

[tegefaulkes]

Specification

The nodes domain manages the agent-agent communications between nodes. This is mostly done inside of NodeConnection and NodeConnectionManager but the NodeManager wraps some of this as well. All of these needs to be reviewed and updated to make use of the TimedCancellable decorator.

Additional context

• Related Integrate TaskManager into NodeGraph and Discovery #445
• Related Apply timedCancellable across the board to control how long side-effects are allowed to complete #450

Tasks

1. Where needed the nodes methods need to be updated to support cancellability.
2. where needed the nodes methods need to use the timedCancellable decorator.
3. parts of the code making use of these timedCancellable methods needs to be updated to exploit this new functionality.
4. Tests need to be expanded to test a wide range of timeout and cancellation conditions.

[tegefaulkes]

This was mostly addressed in #445 . It just needs further review and possibly test updates.

[CMCDragonkai]

Regarding 4.

There are several layers of the nodes tests.

Unit-level tests on the nodes domain can make use of mocking for simple testing.

But more complex testing can be moved into the integration tests... and that relates to moving the integration tests into its own directory.

When you're reviewing the nodes tests, can you take note of any tests can be moved around, so that tests/nodes is more lighter weight, but also more flexible so we can apply fast check to them.

I suspect mocking will be required there.

[tegefaulkes]

NodeConnectionManager.withConnG is a generator but still needs to take the ctx: ContextTimed because it could establish a new connection. I don't think the decorators support generators yet. Right now i'm just optionally taking the the context and just passing that along.

I'm not sure if there's a better way for this.

[tegefaulkes]

The NodeConnectionManager has a dynamic parameter for setting the connection timeouts connConnectTime. but not all of the timedCancellable methods has a corresponding timeout parameter to use. pingNode should have it's own timeout parameter in the NodeConnectionManager.

The NodeManager wraps some methods from the NodeConnectionManager in it's own timedCancellable methods. They should dynamically get the timeout value as well but it doesn't seem right to set them in the NodeManager. I'll make it take the values from the NodeConnectionManager as well.

[tegefaulkes]

NAT tests are still failing, that will have to be looked at next.