Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean stop for widget server #80

Open
mustafasoylu opened this issue May 4, 2023 · 1 comment
Open

Clean stop for widget server #80

mustafasoylu opened this issue May 4, 2023 · 1 comment
Labels
enhancement New feature or request internals Technical and subtle issues users are (usually) not aware of widgets Related to Metador widgets and dashboard system.

Comments

@mustafasoylu
Copy link
Contributor

Currently, the only way to stop the bokeh server is by doing sending sigterm (ctrl+c). There should be a function that uses the clean stop function.

I believe it can be easily implemented by adjusting the run function and add a stop function in widget server.

@mustafasoylu mustafasoylu added the enhancement New feature or request label May 4, 2023
@github-actions github-actions bot added the triage Freshly opened or reopened issue label May 4, 2023
@apirogov apirogov removed the triage Freshly opened or reopened issue label May 4, 2023
@apirogov
Copy link
Collaborator

The problem is not with the bokeh stop function, but with the IOLoop. Running the ioloop.start method blocks the thread. For a clean shutdown thus multithreading is needed, so that the process can somehow receive a stop (or restart) command, e.g. from a flask endpoint.

This is of course also doable, but its a bit more than just calling start and stop. But surely would be nice to have e.g. WidgetServer.run(block=False) or something like that (by default it would use the blocking way to run it)

@apirogov apirogov added internals Technical and subtle issues users are (usually) not aware of widgets Related to Metador widgets and dashboard system. labels Aug 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request internals Technical and subtle issues users are (usually) not aware of widgets Related to Metador widgets and dashboard system.
Projects
None yet
Development

No branches or pull requests

2 participants