Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CDO classes #9

Open
aazocar opened this issue Mar 6, 2023 · 3 comments
Open

CDO classes #9

aazocar opened this issue Mar 6, 2023 · 3 comments
Assignees

Comments

@aazocar
Copy link

aazocar commented Mar 6, 2023

Some adjustments are needed for CDO classes, in order to coherently extend the ontology. Specifically:

  • The Grain Boundary class is not needed on this level, I propose just one class PlaneDefect, the Grain Boundary class can be extended later on.
  • Include another class Bulk Defect
  • Also, LineDefect could be included here as superclass of dislocation? Considering you want to include a disclination class, if not, I guess having LineDefect as equivalent to Dislocation works.

Picture for reference:
Screenshot from 2023-03-06 17-36-13

Let me know what you think!

@az-ihsan az-ihsan self-assigned this Jul 11, 2023
@az-ihsan
Copy link
Collaborator

az-ihsan commented Jul 11, 2023

Hi @aazocar, thanks for the review.

That makes sense now and I'll try to incorporate within the next few days. Other than that, having a disclination class is not worth to take as we also discussed with Stefan about this. So we won't include that.

@az-ihsan
Copy link
Collaborator

@aazocar would you fix it by yourself making a pull request? or let me fix it?

@aazocar
Copy link
Author

aazocar commented Jul 11, 2023

Hi @az-ihsan, thanks for checking. I think you can fix it as you see fit. Since you have a better idea how the changes should be made :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants