Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set transaction isolation to strict serializable #657

Merged
merged 2 commits into from
Sep 28, 2024

Conversation

bobbyiliev
Copy link
Contributor

Explicitly set the transaction isolation level to 'strict serializable' for each db client.

Fixes #656

@bobbyiliev bobbyiliev requested a review from a team as a code owner September 27, 2024 09:53
@bobbyiliev bobbyiliev requested review from SangJunBak and removed request for a team September 27, 2024 09:53
@@ -48,6 +48,7 @@ services:
- --system-parameter-default=max_clusters=100
- --system-parameter-default=max_sources=100
- --system-parameter-default=max_aws_privatelink_connections=10
- --system-parameter-default=transaction_isolation=serializable
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Setting the transaction isolation level to serializable for the second region, that way we will make sure that even if the default value is not set to strict serializable, everything will still work as the provider will explicitly set the level to strict serializable.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Smart!

@matthelm
Copy link

Thanks for your help!

Copy link
Contributor

@arusahni arusahni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@bobbyiliev bobbyiliev merged commit 6cc27a1 into main Sep 28, 2024
4 checks passed
@bobbyiliev bobbyiliev deleted the set-transaction-isolation branch September 28, 2024 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Set transaction isolation to strict for new connections
4 participants