Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

materialize_source_table_kafka: Include envelope_type, key_format and value_format in read func #665

Open
bobbyiliev opened this issue Oct 28, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@bobbyiliev
Copy link
Contributor

Feature request

@rjobanp has added envelope, key_format, and value_format columns to the mz_internal.mz_kafka_source_tables table in this PR.

We need to extend the logic in the read function within resource_source_table_kafka.go to introduce parsing and mapping logic for the complex envelope, key, and value Terraform schema structures.

The new table values look like:

materialize=> select * from mz_internal.mz_kafka_source_tables;
  id  | topic  |      envelope_type      | key_format | value_format 
------+--------+-------------------------+------------+--------------
 u333 | topic1 | none                    |            | 
 u529 | topic1 | upsert-value-err-inline | text       | text

We need to:

  1. Parse the envelope, key_format, and value_format columns from the mz_internal.mz_kafka_source_tables.
  2. Map these parsed values to the appropriate Terraform schema.
  3. Ensure the complex structures are accurately reflected in the resource state, especially for envelope_type, which may impact the resource behavior in Terraform.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant