Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get driver version automatically instead of hardcoding it in the application name #56

Open
bobbyiliev opened this issue Oct 29, 2024 · 0 comments

Comments

@bobbyiliev
Copy link
Contributor

At the moment the application name is set as follows with a hardcoded driver version, we should find a way to get that from the plugin manifest instead:

(defmethod sql-jdbc.conn/connection-details->spec :materialize
  [_ details]
  (let [merged-details (merge default-materialize-connection-details details)
        ;; TODO: get the driver version from the plugin manifest instead of hardcoding it
        driver-version "v1.2.1"
        app-name       (format "Metabase Materialize driver %s %s"
                             driver-version
                             config/mb-app-id-string)]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant