[DNM]: Initial read holds implementation #22976
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maddyblue
commented
Nov 6, 2023
|
|
||
| The `HOLD` object has an associated time that must be written down somewhere on creation then updated on advancement. | ||
| This will use a persist shard to back it, and is thus similar to a 1-row table. | ||
| As a result of not storing it in the catalog (see Alternatives for the motivation), the `AT <time>` syntax must not be part of the `create_sql` of the `HOLD` object and must be purified away. |
There was a problem hiding this comment.
Unclear if this needs to matter or not. It's possible the AT should be purified (that is, if not present, it is added to the statement) and persisted in the catalog (and show up for the SHOW commands), but bootstrap is smart enough to ignore it on restart. Thoughts?
maddyblue
changed the title
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP.
See MaterializeInc/database-issues#6895, MaterializeInc/database-issues#5094
Motivation
Tips for reviewer
Checklist
$T ⇔ Proto$Tmapping (possibly in a backwards-incompatible way), then it is tagged with aT-protolabel.