parallel-workload: sources using data-ingest & sinks #22299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
def-
force-pushed
the
pr-parallel-workload-sinks
branch
3 times, most recently
from
07d17e0
to
46309d8
Compare
def-
force-pushed
the
pr-parallel-workload-sinks
branch
5 times, most recently
from
c266cd9
to
466d2ed
Compare
def-
changed the title
nrainer-materialize
approved these changes
Oct 18, 2023
| def to_pw_type( | ||
| di_type: type[materialize.data_ingest.data_type.DataType], | ||
| ) -> type[DataType]: | ||
| if di_type == materialize.data_ingest.data_type.StringType: |
There was a problem hiding this comment.
What does the di_ prefix stand for?
pw_type is pgwire type?
There was a problem hiding this comment.
di was data-ingest, pw parallel-workload. I now unified the types.
nrainer-materialize
approved these changes
Oct 18, 2023
def-
force-pushed
the
pr-parallel-workload-sinks
branch
from
105d64f
to
b96724c
Compare
philip-stoev
approved these changes
Oct 18, 2023
def-
force-pushed
the
pr-parallel-workload-sinks
branch
3 times, most recently
from
a9ffaaf
to
a3361f5
Compare
def-
force-pushed
the
pr-parallel-workload-sinks
branch
from
a3361f5
to
bb79768
Compare
def-
force-pushed
the
pr-parallel-workload-sinks
branch
from
bb79768
to
00b2e1a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Blocked by https://github.com/MaterializeInc/database-issues/issues/6785 (which this PR found)
Checklist
$T ⇔ Proto$Tmapping (possibly in a backwards-incompatible way), then it is tagged with aT-protolabel.