WIP: Temp #21658
Closed
WIP: Temp #21658
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Support constraining the precision of the fractional seconds in
`timestamp` and `timestamptz` values, as in:
> SELECT '1970-01-01T00:00:00.666666'::timestamp(3) with time zone
1970-01-01T00:00:00:00.667
Valid precisions are 0 through 6, where the maximum precision
corresponds to the existing maximum resolution of one microsecond.
This feature comes from PostgreSQL (and possibly the SQL standard; I
didn't check).
While timestamp precision is relatively unimportant on its own, it
unlocks an important Avro feature: generating Avro schemas for
Avro-formatted sinks that use the "timestamp-millis" logical type rather
than the "timestamp-micros" logical type. Specifically, after this
commit, any `timestamp` or `timestamptz` type with a precision of three
or less will be emitted with logical type `timestamp-millis` rather than
`timestamp-micros`.
Fix #21559.
fix tests
|
|
fixing docs Updated round to precision and added unit tests not using disallowed method making RangeContainsElem check same for both Timestamp and TimestampTz Updated test, added 0 precision fix fmt fix sqllogictests Fixing error message more tests fix tests? fix test adding to scalar type enumerate and interesting datums test moar tests!! test!!!! and moar added new tests as per review comments adding more test cases Keeping CastDateToString
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Tips for reviewer
Checklist
$T ⇔ Proto$Tmapping (possibly in a backwards-incompatible way), then it is tagged with aT-protolabel.