Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "adapter: Create deterministic log index IDs (#30603)" #30649

Closed
wants to merge 2 commits into from

Conversation

ggevay
Copy link
Contributor

@ggevay ggevay commented Nov 28, 2024

This reverts commit 14cc787 to get around a release blocker issue: https://github.com/MaterializeInc/database-issues/issues/8799

Discussion here:
https://materializeinc.slack.com/archives/CTESPM7FU/p1732813333249199?thread_ts=1732808221.986649&cid=CTESPM7FU

Motivation

Tips for reviewer

Checklist

  • This PR has adequate test coverage / QA involvement has been duly considered. (trigger-ci for additional test/nightly runs)
  • This PR has an associated up-to-date design doc, is a design doc (template), or is sufficiently small to not require a design.
  • If this PR evolves an existing $T ⇔ Proto$T mapping (possibly in a backwards-incompatible way), then it is tagged with a T-proto label.
  • If this PR will require changes to cloud orchestration or tests, there is a companion cloud PR to account for those changes that is tagged with the release-blocker label (example).
  • If this PR includes major user-facing behavior changes, I have pinged the relevant PM to schedule a changelog post.

@teskje
Copy link
Contributor

teskje commented Nov 28, 2024

I've added a second commit to add back the two removed proto fields. buf was complaining about them being removed and since we are planning to add these ID variants back, it seems easier to leave their proto fields and not use them than trying to convince buf to accept a breaking change.

@benesch
Copy link
Member

benesch commented Nov 28, 2024

On a hunch, I merged #30650 but I propose we hold off on merging this for a moment. I'm hopeful that the deterministic log ID migration will work in isolation, and then we can follow up with adding the LIR introspection sources in the next release.

@ggevay
Copy link
Contributor Author

ggevay commented Nov 28, 2024

Ok, holding off on this one

@ggevay ggevay closed this Nov 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants