Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix inter-line deadzone in hexdump view #881

Open
therealryan opened this issue Jul 31, 2024 · 2 comments
Open

Fix inter-line deadzone in hexdump view #881

therealryan opened this issue Jul 31, 2024 · 2 comments
Labels
enhancement New feature or request good first issue Good for newcomers javascript Pull requests that update Javascript code

Comments

@therealryan
Copy link
Collaborator

You can roll the pointer over the bytes displayed in the hex view (for example) and the hovered value is explained at the top of the dump.

The transition between side-by-side bytes is fine - there is no gap so the explanation flicks from one value directly to the next.
The transition between one-above-the-other bytes is less good - there's a wee inter-line deadzone where the explanation flicks to blank. This is very minor but kind of annoying - it'd be nicer if the bytes were displayed as a seamless grid with no inter-line gaps in the hover coverage.

@therealryan therealryan added enhancement New feature or request good first issue Good for newcomers javascript Pull requests that update Javascript code labels Jul 31, 2024
@therealryan
Copy link
Collaborator Author

therealryan commented Aug 6, 2024

While we're at it we should look at the inter-line gaps in the message views - they make box-drawing characters less useful. e.g.:

┌───┬─┐
│   │ │
├───┼─┤
└───┴─┘

should be displayed without gaps between the vertical elements

@therealryan
Copy link
Collaborator Author

For the message view: line-height:normal does the trick

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers javascript Pull requests that update Javascript code
Projects
None yet
Development

No branches or pull requests

1 participant