Dev-Issue #97

MartinWitt · 2022-09-05T16:41:32Z

No description provided.

MartinWitt · 2022-09-05T16:41:41Z

@laughing-train mining

MartinWitt · 2022-09-05T16:44:00Z

@laughing-train mining

MartinWitt · 2022-09-05T16:45:49Z

@laughing-train mining

MartinWitt · 2022-09-05T16:51:39Z

@laughing-train mining

MartinWitt · 2022-09-05T18:04:30Z

@laughing-train mining

MartinWitt · 2022-09-05T18:58:40Z

@laughing-train mining

MartinWitt · 2022-09-05T19:00:24Z

@laughing-train mining

MartinWitt · 2022-09-05T20:17:49Z

@laughing-train mining

MartinWitt · 2022-09-05T20:34:16Z

@laughing-train mining

MartinWitt · 2022-09-05T20:38:31Z

@laughing-train mining

MartinWitt · 2022-09-05T20:51:31Z

@laughing-train mining

MartinWitt · 2022-09-05T21:06:49Z

@laughing-train mining

MartinWitt · 2022-09-05T21:08:00Z

@laughing-train mining

MartinWitt · 2022-09-05T21:17:01Z

@laughing-train mining

MartinWitt · 2022-09-05T21:22:05Z

@laughing-train mining

MartinWitt · 2022-09-05T21:49:59Z

@laughing-train mining

MartinWitt · 2022-09-05T21:58:14Z

@laughing-train mining

MartinWitt · 2022-09-05T22:33:35Z

@laughing-train mining

MartinWitt · 2022-09-05T23:18:12Z

@laughing-train mining

MartinWitt · 2022-09-05T23:58:18Z

@laughing-train mining

MartinWitt · 2022-09-06T00:06:09Z

@laughing-train mining

MartinWitt · 2022-09-06T17:39:53Z

@laughing-train mining

MartinWitt · 2022-09-06T17:42:09Z

@laughing-train mining

MartinWitt · 2022-09-06T17:54:31Z

@laughing-train mining

MartinWitt · 2022-09-06T18:07:31Z

@laughing-train mining

MartinWitt · 2022-09-06T18:33:21Z

@laughing-train mining

MartinWitt · 2022-09-06T18:54:28Z

@laughing-train mining

MartinWitt · 2022-09-07T16:45:59Z

@laughing-train mining

MartinWitt · 2022-09-07T16:47:59Z

@laughing-train mining

MartinWitt · 2022-09-07T16:56:58Z

@laughing-train mining

MartinWitt · 2022-09-07T17:16:25Z

@laughing-train mining

MartinWitt · 2022-09-07T17:51:18Z

@laughing-train mining

MartinWitt · 2022-09-07T18:11:50Z

@laughing-train mining

MartinWitt · 2022-09-07T18:38:35Z

@laughing-train mining

MartinWitt · 2022-09-07T19:12:23Z

@laughing-train mining

MartinWitt · 2022-09-07T23:35:17Z

@laughing-train mining

MartinWitt · 2022-09-07T23:41:49Z

@laughing-train mining

MartinWitt · 2022-09-07T23:57:20Z

@laughing-train mining

MartinWitt · 2022-09-08T00:08:59Z

@laughing-train mining

MartinWitt · 2022-09-08T17:10:46Z

@laughing-train mining

MartinWitt · 2022-09-17T15:03:22Z

@laughing-train list

laughing-train · 2022-09-17T15:03:25Z

Bad smells

I found 0 bad smells:

laughing-train · 2022-09-17T15:03:26Z

Bad smells

I found 0 bad smells:

MartinWitt · 2022-09-17T15:19:20Z

@laughing-train list

laughing-train · 2022-09-17T15:19:29Z

Bad smells

I found 0 bad smells:

MartinWitt · 2022-09-17T15:27:29Z

@laughing-train list

MartinWitt · 2022-09-17T16:14:02Z

@laughing-train list

MartinWitt · 2022-09-17T16:22:57Z

@laughing-train list

laughing-train · 2022-09-17T16:30:38Z

Bad smells

I found 10 bad smells:

UnnecessaryToStringCall

Unnecessary toString() call
in code-transformation/src/main/java/xyz/keksdose/spoon/code_solver/transformations/qodana/CollectionEmptyCheck.java

Snippet

        CtType<?> parent = element.getParent(CtType.class).getTopLevelType();
        String raw = "Replaced " + element + " with " + innvocation.toString();
        String markdown = "Replaced `" + element + "` with `" + innvocation.toString() + "`";
        setChanged(parent, new Change(COLLECTION_EMPTY_CHECK, MarkdownString.fromMarkdown(raw, markdown), parent));
    }

UnnecessaryToStringCall

Unnecessary toString() call
in code-transformation/src/main/java/xyz/keksdose/spoon/code_solver/analyzer/qodana/rules/UnnecessaryToStringCall.java

Snippet

        for (CtInvocation<?> toStringInvocations : type.getElements(new InvocationFilter(toStringMethod))) {
            if (isAlmostMatch(toStringInvocations)) {
                String oldInvocation = "" + toStringInvocations.toString();
                toStringInvocations.replace(toStringInvocations.getTarget());
                toStringInvocations

UnnecessaryToStringCall

Unnecessary toString() call
in github-bot/src/main/java/io/github/martinwitt/laughing_train/App.java

Snippet

            TransformationEngine transformationEngine = new TransformationEngine(List.of(function));
            transformationEngine.setChangeListener(changeListener);
            System.out.println("refactorRepo: " + dir.toString() + "/" + config.getSrcFolder());
            transformationEngine.applyToGivenPath(dir.toString() + "/" + config.getSrcFolder());
        } catch (Exception e) {

UnnecessaryToStringCall

Unnecessary toString() call
in github-bot/src/main/java/io/github/martinwitt/laughing_train/App.java

Snippet

            transformationEngine.setChangeListener(changeListener);
            System.out.println("refactorRepo: " + dir.toString() + "/" + config.getSrcFolder());
            transformationEngine.applyToGivenPath(dir.toString() + "/" + config.getSrcFolder());
        } catch (Exception e) {
            logger.atSevere().withCause(e).log("Failed to refactor repo");

UnnecessaryLocalVariable

Local variable junit5AssertTrue is redundant
in code-transformation/src/main/java/xyz/keksdose/spoon/code_solver/transformations/junit/simplification/AssertFalseSameCheck.java

Snippet

    public void process(CtInvocation<?> invocation) {
        if (invocation.getExecutable() != null && JunitHelper.isJunit5AssertFalse(invocation.getExecutable())) {
            CtInvocation<?> junit5AssertTrue = invocation;
            CtExpression<?> expression = invocation.getArguments().iterator().next();
            if (expression instanceof CtBinaryOperator) {

UnnecessaryLocalVariable

Local variable junit5AssertTrue is redundant
in code-transformation/src/main/java/xyz/keksdose/spoon/code_solver/transformations/junit/simplification/AssertNullTransformation.java

Snippet

    public void process(CtInvocation<?> invocation) {
        if (invocation.getExecutable() != null && JunitHelper.isJunit5AssertTrue(invocation.getExecutable())) {
            CtInvocation<?> junit5AssertTrue = invocation;
            CtExpression<?> expression = invocation.getArguments().iterator().next();
            if (expression instanceof CtBinaryOperator) {

UnnecessaryLocalVariable

Local variable junit5AssertTrue is redundant
in code-transformation/src/main/java/xyz/keksdose/spoon/code_solver/transformations/junit/simplification/AssertNotNullTransformation.java

Snippet

    public void process(CtInvocation<?> element) {
        if (element.getExecutable() != null && JunitHelper.isJunit5AssertTrue(element.getExecutable())) {
            CtInvocation<?> junit5AssertTrue = element;
            CtExpression<?> expression = element.getArguments().iterator().next();
            if (expression instanceof CtBinaryOperator) {

UnnecessaryLocalVariable

Local variable junit5AssertTrue is redundant
in code-transformation/src/main/java/xyz/keksdose/spoon/code_solver/transformations/junit/simplification/AssertTrueSameCheck.java

Snippet

    public void process(CtInvocation<?> invocation) {
        if (invocation.getExecutable() != null && JunitHelper.isJunit5AssertTrue(invocation.getExecutable())) {
            CtInvocation<?> junit5AssertTrue = invocation;
            CtExpression<?> expression = invocation.getArguments().iterator().next();
            if (expression instanceof CtBinaryOperator) {

UnnecessaryLocalVariable

Local variable junit5AssertTrue is redundant
in code-transformation/src/main/java/xyz/keksdose/spoon/code_solver/transformations/junit/simplification/AssertFalseEqualsCheck.java

Snippet

    public void process(CtInvocation<?> invocation) {
        if (invocation.getExecutable() != null && JunitHelper.isJunit5AssertFalse(invocation.getExecutable())) {
            CtInvocation<?> junit5AssertTrue = invocation;
            CtExpression<?> expression = invocation.getArguments().iterator().next();
            if (expression instanceof CtInvocation) {

UnnecessaryLocalVariable

Local variable junit5AssertTrue is redundant
in code-transformation/src/main/java/xyz/keksdose/spoon/code_solver/transformations/junit/simplification/AssertTrueEqualsCheck.java

Snippet

    public void process(CtInvocation<?> invocation) {
        if (invocation.getExecutable() != null && JunitHelper.isJunit5AssertTrue(invocation.getExecutable())) {
            CtInvocation<?> junit5AssertTrue = invocation;
            CtExpression<?> expression = invocation.getArguments().iterator().next();
            if (expression instanceof CtInvocation) {

MartinWitt · 2022-09-17T16:59:36Z

@laughing-train list

laughing-train · 2022-09-17T17:07:17Z

Bad smells

I found 10 bad smells:

UnnecessaryToStringCall

Unnecessary toString() call
in code-transformation/src/main/java/xyz/keksdose/spoon/code_solver/transformations/qodana/CollectionEmptyCheck.java

Snippet

        CtType<?> parent = element.getParent(CtType.class).getTopLevelType();
        String raw = "Replaced " + element + " with " + innvocation.toString();
        String markdown = "Replaced `" + element + "` with `" + innvocation.toString() + "`";
        setChanged(parent, new Change(COLLECTION_EMPTY_CHECK, MarkdownString.fromMarkdown(raw, markdown), parent));
    }

UnnecessaryToStringCall

Unnecessary toString() call
in code-transformation/src/main/java/xyz/keksdose/spoon/code_solver/analyzer/qodana/rules/UnnecessaryToStringCall.java

Snippet

        for (CtInvocation<?> toStringInvocations : type.getElements(new InvocationFilter(toStringMethod))) {
            if (isAlmostMatch(toStringInvocations)) {
                String oldInvocation = "" + toStringInvocations.toString();
                toStringInvocations.replace(toStringInvocations.getTarget());
                toStringInvocations

UnnecessaryToStringCall

Unnecessary toString() call
in github-bot/src/main/java/io/github/martinwitt/laughing_train/App.java

Snippet

            TransformationEngine transformationEngine = new TransformationEngine(List.of(function));
            transformationEngine.setChangeListener(changeListener);
            System.out.println("refactorRepo: " + dir.toString() + "/" + config.getSrcFolder());
            transformationEngine.applyToGivenPath(dir.toString() + "/" + config.getSrcFolder());
        } catch (Exception e) {

UnnecessaryToStringCall

Unnecessary toString() call
in github-bot/src/main/java/io/github/martinwitt/laughing_train/App.java

Snippet

            transformationEngine.setChangeListener(changeListener);
            System.out.println("refactorRepo: " + dir.toString() + "/" + config.getSrcFolder());
            transformationEngine.applyToGivenPath(dir.toString() + "/" + config.getSrcFolder());
        } catch (Exception e) {
            logger.atSevere().withCause(e).log("Failed to refactor repo");

UnnecessaryLocalVariable

Local variable junit5AssertTrue is redundant
in code-transformation/src/main/java/xyz/keksdose/spoon/code_solver/transformations/junit/simplification/AssertFalseSameCheck.java

Snippet

    public void process(CtInvocation<?> invocation) {
        if (invocation.getExecutable() != null && JunitHelper.isJunit5AssertFalse(invocation.getExecutable())) {
            CtInvocation<?> junit5AssertTrue = invocation;
            CtExpression<?> expression = invocation.getArguments().iterator().next();
            if (expression instanceof CtBinaryOperator) {

UnnecessaryLocalVariable

Local variable junit5AssertTrue is redundant
in code-transformation/src/main/java/xyz/keksdose/spoon/code_solver/transformations/junit/simplification/AssertNullTransformation.java

Snippet

    public void process(CtInvocation<?> invocation) {
        if (invocation.getExecutable() != null && JunitHelper.isJunit5AssertTrue(invocation.getExecutable())) {
            CtInvocation<?> junit5AssertTrue = invocation;
            CtExpression<?> expression = invocation.getArguments().iterator().next();
            if (expression instanceof CtBinaryOperator) {

UnnecessaryLocalVariable

Local variable junit5AssertTrue is redundant
in code-transformation/src/main/java/xyz/keksdose/spoon/code_solver/transformations/junit/simplification/AssertNotNullTransformation.java

Snippet

    public void process(CtInvocation<?> element) {
        if (element.getExecutable() != null && JunitHelper.isJunit5AssertTrue(element.getExecutable())) {
            CtInvocation<?> junit5AssertTrue = element;
            CtExpression<?> expression = element.getArguments().iterator().next();
            if (expression instanceof CtBinaryOperator) {

UnnecessaryLocalVariable

Local variable junit5AssertTrue is redundant
in code-transformation/src/main/java/xyz/keksdose/spoon/code_solver/transformations/junit/simplification/AssertTrueSameCheck.java

Snippet

    public void process(CtInvocation<?> invocation) {
        if (invocation.getExecutable() != null && JunitHelper.isJunit5AssertTrue(invocation.getExecutable())) {
            CtInvocation<?> junit5AssertTrue = invocation;
            CtExpression<?> expression = invocation.getArguments().iterator().next();
            if (expression instanceof CtBinaryOperator) {

UnnecessaryLocalVariable

Local variable junit5AssertTrue is redundant
in code-transformation/src/main/java/xyz/keksdose/spoon/code_solver/transformations/junit/simplification/AssertFalseEqualsCheck.java

Snippet

    public void process(CtInvocation<?> invocation) {
        if (invocation.getExecutable() != null && JunitHelper.isJunit5AssertFalse(invocation.getExecutable())) {
            CtInvocation<?> junit5AssertTrue = invocation;
            CtExpression<?> expression = invocation.getArguments().iterator().next();
            if (expression instanceof CtInvocation) {

UnnecessaryLocalVariable

Local variable junit5AssertTrue is redundant
in code-transformation/src/main/java/xyz/keksdose/spoon/code_solver/transformations/junit/simplification/AssertTrueEqualsCheck.java

Snippet

    public void process(CtInvocation<?> invocation) {
        if (invocation.getExecutable() != null && JunitHelper.isJunit5AssertTrue(invocation.getExecutable())) {
            CtInvocation<?> junit5AssertTrue = invocation;
            CtExpression<?> expression = invocation.getArguments().iterator().next();
            if (expression instanceof CtInvocation) {

Dev-Issue #97

Dev-Issue #97

Comments

MartinWitt commented Sep 5, 2022

MartinWitt commented Sep 5, 2022

MartinWitt commented Sep 5, 2022

MartinWitt commented Sep 5, 2022

MartinWitt commented Sep 5, 2022

MartinWitt commented Sep 5, 2022

MartinWitt commented Sep 5, 2022

MartinWitt commented Sep 5, 2022

MartinWitt commented Sep 5, 2022

MartinWitt commented Sep 5, 2022

MartinWitt commented Sep 5, 2022

MartinWitt commented Sep 5, 2022

MartinWitt commented Sep 5, 2022

MartinWitt commented Sep 5, 2022

MartinWitt commented Sep 5, 2022

MartinWitt commented Sep 5, 2022

MartinWitt commented Sep 5, 2022

MartinWitt commented Sep 5, 2022

MartinWitt commented Sep 5, 2022

MartinWitt commented Sep 5, 2022

MartinWitt commented Sep 5, 2022

MartinWitt commented Sep 6, 2022

MartinWitt commented Sep 6, 2022

MartinWitt commented Sep 6, 2022

MartinWitt commented Sep 6, 2022

MartinWitt commented Sep 6, 2022

MartinWitt commented Sep 6, 2022

MartinWitt commented Sep 6, 2022

MartinWitt commented Sep 7, 2022

MartinWitt commented Sep 7, 2022

MartinWitt commented Sep 7, 2022

MartinWitt commented Sep 7, 2022

MartinWitt commented Sep 7, 2022

MartinWitt commented Sep 7, 2022

MartinWitt commented Sep 7, 2022

MartinWitt commented Sep 7, 2022

MartinWitt commented Sep 7, 2022

MartinWitt commented Sep 7, 2022

MartinWitt commented Sep 7, 2022

MartinWitt commented Sep 8, 2022

MartinWitt commented Sep 8, 2022

MartinWitt commented Sep 17, 2022

laughing-train bot commented Sep 17, 2022

Bad smells

laughing-train bot commented Sep 17, 2022

Bad smells

MartinWitt commented Sep 17, 2022

laughing-train bot commented Sep 17, 2022

Bad smells

MartinWitt commented Sep 17, 2022

MartinWitt commented Sep 17, 2022

MartinWitt commented Sep 17, 2022

laughing-train bot commented Sep 17, 2022

Bad smells

UnnecessaryToStringCall

Snippet

UnnecessaryToStringCall

Snippet

UnnecessaryToStringCall

Snippet

UnnecessaryToStringCall

Snippet

UnnecessaryLocalVariable

Snippet

UnnecessaryLocalVariable

Snippet

UnnecessaryLocalVariable

Snippet

UnnecessaryLocalVariable

Snippet

UnnecessaryLocalVariable

Snippet

UnnecessaryLocalVariable

Snippet

MartinWitt commented Sep 17, 2022

laughing-train bot commented Sep 17, 2022

Bad smells