Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verify=False is not propogated to bypass ssl verification #386

Open
phinds1 opened this issue Mar 4, 2024 · 4 comments
Open

Verify=False is not propogated to bypass ssl verification #386

phinds1 opened this issue Mar 4, 2024 · 4 comments

Comments

@phinds1
Copy link

phinds1 commented Mar 4, 2024

Version: 7.0 (Python 3.10.12 on linux)

ref this https://forum.robotframework.org/t/how-to-make-requests-library-ignore-ssl-errors/6790/8

in _common_request() function

    resp = method_function(
        self._merge_url(session, uri),  <- session has verify:False but it is not passed to kwargs
        timeout=self._get_timeout(kwargs.pop('timeout', None)),
        cookies=kwargs.pop('cookies', self.cookies),
        **kwargs)
log.logger.error(kwargs)  <- this is missing Verify: False

kwargs.update({'verify': False})  <-  if I add it it works

My guess this is missing

kwargs.update({'verify': session.verify})   
@lucagiove
Copy link
Member

It's a guess or this solution is confirmed?

@phinds1
Copy link
Author

phinds1 commented Mar 4, 2024

Has the Works on my Machine™ star of approval. :) Tested on Ubuntu latest

The "guess" is what was intended: potentially more attributes need to be copied and some other step got missed during a refactoring? Presumably verfiy=False worked at some point?

@phinds1
Copy link
Author

phinds1 commented Mar 15, 2024

Anything more needed from me? I submitted a PR

#387

@andre-s-pedrosa-alb
Copy link

andre-s-pedrosa-alb commented Mar 21, 2024

This was also happening to me with
robotframework==6.1.1
robotframework-requests==0.9.4

the fix in the PR fixed the issue of ssl verification not being skipped with verify=False

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants