Feature/minor corrections (#42)

* weird typo in gitlab ci did this actual work before? * some minor corrections * some minor corrections
MarketSquare · Sep 13, 2021 · c32016b · c32016b
1 parent 88d36ab
commit c32016b
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 5 deletions.
diff --git a/CamundaLibrary/CamundaLibrary.py b/CamundaLibrary/CamundaLibrary.py
@@ -70,7 +70,7 @@ class CamundaLibrary:
 
     == Subscribing a topic / long polling ==
     You may achieve a kind of subscription by providing the ``asyncResponseTimeout`` with the `Fetch workload`
-    keyword in order to achieve [https://docs.camunda.org/manual/7.14/user-guide/process-engine/external-tasks/#long-polling-to-fetch-and-lock-external-tasks|Long Polling].
+    keyword in order to achieve [https://docs.camunda.org/manual/latest/user-guide/process-engine/external-tasks/#long-polling-to-fetch-and-lock-external-tasks|Long Polling].
 
     | ${variables} | fetch workload | my_topic | async_response_timeout=60000 |
     | log | Waited at most 1 minute before this log statement got executed |
@@ -83,7 +83,7 @@ class CamundaLibrary:
     = Feedback =
 
     Feedback is very much appreciated regardless if it is comments, reported issues, feature requests or even merge
-    requests. You are welcome to participating in any way at the [https://gitlab.com/postadress/robotframework/robotframework-camunda|GitLab project of CamundaLibrary].
+    requests. You are welcome to participating in any way at the [https://github.com/MarketSquare/robotframework-camunda|GitHub project of CamundaLibrary].
     """
 
     WORKER_ID = f'robotframework-camundalibrary-{time.time()}'
@@ -447,7 +447,7 @@ def bpmn_error(self, error_code: str, error_message: str = None, variables: Dict
                 except ApiException as e:
                     logger.error(f"Exception when calling ExternalTaskApi->handle_external_task_bpmn_error: {e}\n")
 
-    @keyword("Notify failure", tags=["task", "beta"])
+    @keyword("Notify failure", tags=["task"])
     def notify_failure(self, **kwargs):
         """
         Raises a failure to Camunda. When retry counter is less than 1, an incident is created by Camunda.
@@ -470,7 +470,6 @@ def notify_failure(self, **kwargs):
                 try:
                     api_instance.handle_failure(id=self.FETCH_RESPONSE.id,
                                                 external_task_failure_dto=external_task_failure_dto)
-                    self.unlock()
                     self.drop_fetch_response()
                 except ApiException as e:
                     logger.error("Exception when calling ExternalTaskApi->handle_failure: %s\n" % e)

diff --git a/tests/robot/ExternalTask/test_notify_failure.robot b/tests/robot/ExternalTask/test_notify_failure.robot
@@ -39,4 +39,4 @@ Test 'Notify failure' for existing topic
 
     ${incident}    Get incidents    process_instance_id=${process_instance}[process_instance_id]
     log    ${incident}
-    Should Not be Empty    ${incident}
+    Should Not be Empty    ${incident}     Getting incident failed. There is no incident availabe matching the process instance.