Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion for spike-field GLM on page /11.html #24

Open
abuzarmahmood opened this issue Apr 26, 2023 · 1 comment
Open

Suggestion for spike-field GLM on page /11.html #24

abuzarmahmood opened this issue Apr 26, 2023 · 1 comment

Comments

@abuzarmahmood
Copy link

It might be helpful to explain why the phase needs to be represented as sin(phi) and cos(phi) instead of regressing to phi directly using the GLM. It took me a bit to realize that log(lambda) cannot be linearly regressed to phase but sin(phi) and cos(phi) can.

Happy to create a PR if this seems useful.

@Mark-Kramer
Copy link
Owner

A very late reply ... correct, the discontinuity at 0/2pi makes regressing on phase problematic. Pull request very much appreciated!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants