Address MSTEST0040 warnings (#4586)

Fixes Csla.Windows.Tests project which can't be executed due to a missing test.runsettings-file.

Author: StefanOssendorf

Source/Csla.Windows.Tests/test.runsettings

@@ -0,0 +1,8 @@
+<?xml version="1.0" encoding="utf-8"?>
+<RunSettings>
+  <MSTest>
+    <Parallelize>
+      <Scope>ClassLevel</Scope>
+    </Parallelize>
+  </MSTest>
+</RunSettings>

Source/Csla.test/DataPortal/AsynchDataPortalTest.cs

@@ -97,28 +97,19 @@ public async Task CreateAsync_WithCriteria()
 
 
     [TestMethod]
-    public void CreateAsync_WithException()
+    public async Task CreateAsync_WithException()
     {
-      var lck = new AutoResetEvent(false);
-      new Action(async () =>
-      {
-        IDataPortal<Single2> dataPortal = _testDIContext.CreateDataPortal<Single2>();
+      IDataPortal<Single2> dataPortal = _testDIContext.CreateDataPortal<Single2>();
 
-        try
-        {
-          var result = await dataPortal.CreateAsync(9999);
-          Assert.Fail("Expected exception not thrown");
-        }
-        catch (Exception ex)
-        {
-          Assert.IsInstanceOfType(ex, typeof(DataPortalException));
-        }
-        finally
-        {
-          lck.Set();
-        }
-      }).Invoke();
-      lck.WaitOne();
+      try
+      {
+        var result = await dataPortal.CreateAsync(9999);
+        Assert.Fail("Expected exception not thrown");
+      }
+      catch (Exception ex)
+      {
+        Assert.IsInstanceOfType(ex, typeof(DataPortalException));
+      }
     }
 
     [TestMethod]
@@ -164,28 +155,19 @@ public async Task FetchAsync_WithCriteria()
 
 
     [TestMethod]
-    public void FetchAsync_WithException()
+    public async Task FetchAsync_WithException()
     {
-      var lck = new AutoResetEvent(false);
-      new Action(async () =>
-      {
-        IDataPortal<Single2> dataPortal = _testDIContext.CreateDataPortal<Single2>();
+      IDataPortal<Single2> dataPortal = _testDIContext.CreateDataPortal<Single2>();
 
-        try
-        {
-          var result = await dataPortal.FetchAsync(9999);
-          Assert.Fail("Expected exception not thrown");
-        }
-        catch (Exception ex)
-        {
-          Assert.IsInstanceOfType(ex, typeof(DataPortalException));
-        }
-        finally
-        {
-          lck.Set();
-        }
-      }).Invoke();
-      lck.WaitOne();
+      try
+      {
+        var result = await dataPortal.FetchAsync(9999);
+        Assert.Fail("Expected exception not thrown");
+      }
+      catch (Exception ex)
+      {
+        Assert.IsInstanceOfType(ex, typeof(DataPortalException));
+      } 
     }
 
     [TestMethod]
@@ -236,24 +218,17 @@ await context.Assert.Try(async () =>
         Assert.AreEqual(555, result.Id);
         Assert.IsTrue(result.IsNew);
         Assert.IsTrue(result.IsDirty);
-        var lck = new AutoResetEvent(false);
-        new Action(async () =>
+        
+        try
+        {
+          result = await result.SaveAsync();
+          Assert.Fail("Expected exception not thrown");
+        }
+        catch (Exception ex)
         {
-          try
-          {
-            result = await result.SaveAsync();
-            Assert.Fail("Expected exception not thrown");
-          }
-          catch (Exception ex)
-          {
-            context.Assert.IsTrue(ex.GetType() == typeof(DataPortalException));
-          }
-          finally
-          {
-            lck.Set();
-          }
-        }).Invoke();
-        lck.WaitOne();
+          context.Assert.IsTrue(ex.GetType() == typeof(DataPortalException));
+        }
+
         context.Assert.Success();
       });
       context.Complete();
@@ -285,29 +260,20 @@ public async Task ExecuteAsync()
     }
 
     [TestMethod]
-    public void ExecuteAsyncWithException()
+    public async Task ExecuteAsyncWithException()
     {
-      var lck = new AutoResetEvent(false);
-      new Action(async () =>
-      {
-        IDataPortal<SingleCommand> dataPortal = _testDIContext.CreateDataPortal<SingleCommand>();
+      IDataPortal<SingleCommand> dataPortal = _testDIContext.CreateDataPortal<SingleCommand>();
 
-        try
-        {
-          var cmd = dataPortal.Create(555);
-          var result = await dataPortal.ExecuteAsync(cmd);
-          Assert.Fail("Expected exception not thrown");
-        }
-        catch (Exception ex)
-        {
-          Assert.IsInstanceOfType(ex, typeof(DataPortalException));
-        }
-        finally
-        {
-          lck.Set();
-        }
-      }).Invoke();
-      lck.WaitOne();
+      try
+      {
+        var cmd = dataPortal.Create(555);
+        var result = await dataPortal.ExecuteAsync(cmd);
+        Assert.Fail("Expected exception not thrown");
+      }
+      catch (Exception ex)
+      {
+        Assert.IsInstanceOfType(ex, typeof(DataPortalException));
+      }
     }
     #endregion