Avoid duplicate dictionary lookup in GetConsolidatedList (#4551)

SimonCropp · web-flow · commit 76cb3229ab78 · 2025-03-03T20:47:31.000-08:00
diff --git a/Source/Csla/Core/FieldManager/FieldDataManager.cs b/Source/Csla/Core/FieldManager/FieldDataManager.cs
@@ -168,9 +168,9 @@ private static List<IPropertyInfo> GetConsolidatedList(
             _consolidatedLists.Add(type, cacheInstance);
           }
 #else
-          if (_consolidatedLists.ContainsKey(type))
+          if (_consolidatedLists.TryGetValue(type, out var list))
           {
-            result = _consolidatedLists[type];
+            result = list;
           }
           else
           {

Original file line number	Diff line number	Diff line change
`@@ -168,9 +168,9 @@ private static List<IPropertyInfo> GetConsolidatedList(`
`168`	`168`	`_consolidatedLists.Add(type, cacheInstance);`
`169`	`169`	`}`
`170`	`170`	`#else`
`171`		`- if (_consolidatedLists.ContainsKey(type))`
	`171`	`+ if (_consolidatedLists.TryGetValue(type, out var list))`
`172`	`172`	`{`
`173`		`- result = _consolidatedLists[type];`
	`173`	`+ result = list;`
`174`	`174`	`}`
`175`	`175`	`else`
`176`	`176`	`{`