Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Listen method does not handle exceptions #106

Open
apobekiaris opened this issue Jan 14, 2022 · 0 comments
Open

Listen method does not handle exceptions #106

apobekiaris opened this issue Jan 14, 2022 · 0 comments

Comments

@apobekiaris
Copy link

apobekiaris commented Jan 14, 2022

let's say ln ln 421 throws an Exception

result = await client.ReceiveAsync(buffer, token);

it will be catched on ln549

Logger.Error(e, L($"Error while listening to websocket stream, error: '{e.Message}'"));

next the method tries to ReconnectSynchronize and assuming we have the same exception the method continues makring the client IsRunning, IsStarted in ln 356 of the StartClient method.

Can you please comment as this flow apparently look buggy to me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant