Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add information about ratelimit to ApodResponse #38

Open
MarcusOtter opened this issue Nov 28, 2019 · 0 comments
Open

Add information about ratelimit to ApodResponse #38

MarcusOtter opened this issue Nov 28, 2019 · 0 comments
Assignees
@MarcusOtter
Labels
enhancement New feature or request
Projects
Library enhancements and features
Milestone
2.0

Comments

@MarcusOtter
Copy link
Owner

Is your feature request related to a problem? Please describe.
There is currently no way of knowing how many requests you have left when using this wrapper.

Describe the feature you'd like
It would be convenient to add two fields HourlyRequestLimit and HourlyRequestsRemaining to the ApodResponse. This can easily be added by reading the headers X-RateLimit-Limit and X-RateLimit-Remaining from the response headers.
@MarcusOtter MarcusOtter added the enhancement New feature or request label Nov 28, 2019
@MarcusOtter MarcusOtter added this to the Nice-to-haves milestone Nov 28, 2019
@MarcusOtter MarcusOtter self-assigned this Nov 28, 2019
@MarcusOtter MarcusOtter added this to To do in Library enhancements and features via automation Nov 28, 2019
@MarcusOtter MarcusOtter modified the milestones: Future, 2.0 Dec 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MarcusOtter MarcusOtter

Labels
enhancement New feature or request
Projects
Library enhancements and features
  
To do
Milestone
2.0
Development

No branches or pull requests
1 participant
@MarcusOtter