-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unpin Python requirements #59
Comments
I am facing similar issue and it seems this has stagnated. Any updates? Trying to install with poetry:
|
Sorry for not reacting on this earlier. We have now created a new alphamap release with loose dependencies. This version should now be compatible with other packages and for integration. Please let us know in case you still encounter any issues! |
Hello, thanks for trying to fix. There's a different issue now.
Edit: It does work if I first create a poetry shell and then |
Thanks for your prompt reply:
|
Overview
https://github.com/MannLabs/alphamap/blob/master/requirements.txt pins a handful of Python package dependencies, e.g. numpy==1.19.2. I cannot decide from the commit history that this is due to specific requirements of alphamap.
Pinning packages makes it difficult to combine alphamap with other packages that also depend on e.g. numpy. Instead, it would be helpful to specify dependencies either open, numpy>=1.19.2, or limited to the next major version (numpy>=1.19.2,<2), assuming dependency maintainers adhere to semantic versioning and don't introduce breaking changes between major versions.
Dependencies that need more specific versions could be pinned with a commit that references the issue describing the reasoning for pinning to exact versions. Then it's easier to go back later and check if the pinning is still necessary.
The text was updated successfully, but these errors were encountered: