Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NaturalNeighboursMethod fail #55

Closed
behinger opened this issue Sep 18, 2024 · 3 comments
Closed

NaturalNeighboursMethod fail #55

behinger opened this issue Sep 18, 2024 · 3 comments

Comments

@behinger
Copy link
Collaborator

Hi @asinghvi17 - the NaturalNeighboursMethod seems to fail, already e.g. in the general.md docs example I get a

ERROR: TaskFailedException

    nested task error: KeyError: key (10, 9, 8) not found

Any idea whats going on?

@behinger
Copy link
Collaborator Author

behinger commented Nov 8, 2024

@asinghvi17 any points on this, else I will take out that example for now. I dont have time to debug that code

palday added a commit that referenced this issue Nov 15, 2024
* fix labels, fix #39

* added a backward compatability with warning

* removed NaturalNeighbours for now until #55 is fixed

* undo indent change

* Apply suggestions from code review

Co-authored-by: Phillip Alday <[email protected]>

* fix code-review issues

* removed old file

* maybe fix @deprecated fail

* fix test

* add missing test

* fix gitignore

* CondaPkg tweak

* labels in test

---------

Co-authored-by: Phillip Alday <[email protected]>
@palday
Copy link
Collaborator

palday commented Nov 15, 2024

closed by #60

@palday palday closed this as completed Nov 15, 2024
palday added a commit that referenced this issue Nov 15, 2024
* fix labels, fix #39

* added a backward compatability with warning

* removed NaturalNeighbours for now until #55 is fixed

* added example of contourf and surface to docs

* remove extra file

* kwarg name tweak, tests

* docs fix

* add cache to documenter

---------

Co-authored-by: Phillip Alday <[email protected]>
palday added a commit that referenced this issue Nov 16, 2024
* fix labels, fix #39

* added a backward compatability with warning

* removed NaturalNeighbours for now until #55 is fixed

* added example of contourf and surface to docs

* added an example with custom bounds #38

* merge fixes

* typo

* remove extra file

* minor formatting

* oops

* re-enable natural neighbours

---------

Co-authored-by: Phillip Alday <[email protected]>
palday added a commit that referenced this issue Nov 16, 2024
* fix labels, fix #39

* added a backward compatability with warning

* removed NaturalNeighbours for now until #55 is fixed

* added example of contourf and surface to docs

* added an example with custom bounds #38

* added 10-05 template electrodes; breaking: new default enlarge = 1.0 for eeg-topoplot only

* renamed     T3 is now T7
    T4 is now T8
    T5 is now P7
    T6 is now P8
according to the MCN system

* fixed 10/20 old labels work now too

* fixed bug

* added test for 10-20/10-05

* fix indent

* formatting

* s/begin/let

* docstrings

* s/warn/warning

* docs fix

* again

* 🤦

* I give up

---------

Co-authored-by: Phillip Alday <[email protected]>
Co-authored-by: Phillip Alday <[email protected]>
@DanielVandH
Copy link

@behinger If you still want to fix it, you can send me the example code that led to that error I can debug it. Usually it's the same cause everytime but a bit hard to explain

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants