Skip to content

Commit ffc31a0

Browse files
authored
fix WGLMakie JS popup (#2976)
* fix popup * clear is an obwservable now
1 parent 268a3df commit ffc31a0

File tree

3 files changed

+5
-3
lines changed

3 files changed

+5
-3
lines changed

WGLMakie/src/picking.jl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -121,7 +121,7 @@ function JSServe.jsrender(session::Session, tt::ToolTip)
121121
$(scene).then(scene => {
122122
const plots_to_pick = new Set($(tt.plot_uuids));
123123
const callback = $(tt.callback);
124-
register_popup($popup, scene, plots_to_pick, callback)
124+
WGL.register_popup($popup, scene, plots_to_pick, callback)
125125
})
126126
""")
127127
return DOM.span(JSServe.jsrender(session, POPUP_CSS), popup)

WGLMakie/src/wglmakie.bundled.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20611,7 +20611,8 @@ window.WGL = {
2061120611
delete_scenes,
2061220612
create_scene,
2061320613
event2scene_pixel,
20614-
on_next_insert
20614+
on_next_insert,
20615+
register_popup
2061520616
};
2061620617
export { deserialize_scene as deserialize_scene, threejs_module as threejs_module, start_renderloop as start_renderloop, delete_plots as delete_plots, insert_plot as insert_plot, find_plots as find_plots, delete_scene as delete_scene, find_scene as find_scene, scene_cache as scene_cache, plot_cache as plot_cache, delete_scenes as delete_scenes, create_scene as create_scene, event2scene_pixel as event2scene_pixel, on_next_insert as on_next_insert };
2061720618
export { render_scene as render_scene };

WGLMakie/src/wglmakie.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ export function render_scene(scene, picking = false) {
3535
if (!scene.visible.value) {
3636
return true;
3737
}
38-
renderer.autoClear = scene.clearscene;
38+
renderer.autoClear = scene.clearscene.value;
3939
const area = scene.pixelarea.value;
4040
if (area) {
4141
const [x, y, w, h] = area.map((t) => t / pixelRatio);
@@ -478,6 +478,7 @@ window.WGL = {
478478
create_scene,
479479
event2scene_pixel,
480480
on_next_insert,
481+
register_popup,
481482
};
482483

483484
export {

0 commit comments

Comments
 (0)