-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add more examples + a basic metadata framework #233
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Datashader won't work, but this is a good approximation
More to come soon
asinghvi17
changed the title
Update index.md
Implement the example gallery via Documenter directly + add Documenter blocks
Jun 8, 2024
@lazarusA you might be interested in examples/basic.jl and docs/example_meta_block.jl here - they have a first prototype for in-code evaluation of an example's metadata (title, description, cover) which we can forward to the Gallery prototype here. (Just have to figure out how to embed/downsize the image now :D) |
for `imresize` mainly.
This sounds like a mistake I will keep making :D
asinghvi17
changed the title
Implement the example gallery via Documenter directly + add Documenter blocks
Add more examples + a basic metadata framework
Jun 8, 2024
TODOs for the next PR:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://geo.makie.org/previews/PR233
The metadata framework doesn't apply to anything yet, but it should do so quite soon! I will have to guard against garbage collection somehow, though. Maybe by setting the value of
cover
to the relevant module?The actual implementation will come in the next PR.