Bump node-ical from 0.16.1 to 0.17.0 #3278
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![dependabot[bot]](https://avatars.githubusercontent.com/in/29110?s=60&v=4){kind=small}
dependabot
bot
added
dependencies
dependabot
bot
force-pushed
the
dependabot/npm_and_yarn/develop/node-ical-0.17.0
branch
from
21b8298 to
9361087
Compare
|
waiting for #3014 |
|
also failing tests with this update... |
|
Api change? |
|
no.. bug fix for MS and multi-location TZ ids and also removal of luxon library from RRULE lib dependencies |
|
that is a timing bug again as far as I can tell.. they all runs the same testcases.. |
|
all tests are fine with new |
|
I had not yet tested node-ical 0.17.0 for side impacts.. |
Merged
|
@dependabot rebase |
dependabot
bot
force-pushed
the
dependabot/npm_and_yarn/develop/node-ical-0.17.0
branch
from
9361087 to
ddd7583
Compare
did you try out node v20? or where di the tests run fine? |
|
I ran tests locally on node 20. no issues |
can not explain why it worked last time. Now the calendar e2e tests are failing reproducable: node@48626ff2d77f:/opt/magic_mirror$ npx jest tests/e2e/modules/calendar_spec.js
(node:240) [DEP0040] DeprecationWarning: The `punycode` module is deprecated. Please use a userland alternative instead.
(Use `node --trace-deprecation ...` to show where the warning was created)
FAIL e2e tests/e2e/modules/calendar_spec.js (189.832 s)
Calendar module
Default configuration
✕ should show the default maximumEntries of 10 (20002 ms)
✕ should show the default calendar symbol in each event (20000 ms)
Custom configuration
✓ should show the custom maximumEntries of 5 (3983 ms)
✓ should show the custom calendar symbol in four events (202 ms)
✓ should show a customEvent calendar symbol in one event (200 ms)
✓ should show a customEvent calendar eventClass in one event (200 ms)
✓ should show two custom icons for repeating events (203 ms)
✕ should show two custom icons for day events (202 ms)
Recurring event
✓ should show the recurring birthday event 6 times (1316 ms)
exdate check
✓ should show the recurring event 51 times (excluded once) in a 364-day (inclusive) period (1353 ms)
Events from multiple calendars
✕ should show multiple events with the same title and start time from different calendars (20000 ms)
Recurring event per timezone
✓ should contain text "Mar 25th" in timezone UTC 12 (1306 ms)
✓ should contain text "Mar 25th" in timezone UTC 11 (1302 ms)
✓ should contain text "Mar 25th" in timezone UTC 10 (1309 ms)
✓ should contain text "Mar 25th" in timezone UTC 9 (1311 ms)
✓ should contain text "Mar 25th" in timezone UTC 8 (1304 ms)
✓ should contain text "Mar 25th" in timezone UTC 7 (1244 ms)
✓ should contain text "Mar 25th" in timezone UTC 6 (1338 ms)
✓ should contain text "Mar 25th" in timezone UTC 5 (1317 ms)
✓ should contain text "Mar 25th" in timezone UTC 4 (1313 ms)
✓ should contain text "Mar 25th" in timezone UTC 3 (1213 ms)
✓ should contain text "Mar 25th" in timezone UTC 2 (1316 ms)
✓ should contain text "Mar 25th" in timezone UTC 1 (1309 ms)
✓ should contain text "Mar 25th" in timezone UTC 0 (1384 ms)
✓ should contain text "Mar 25th" in timezone UTC -1 (1344 ms)
✓ should contain text "Mar 25th" in timezone UTC -2 (1335 ms)
✓ should contain text "Mar 25th" in timezone UTC -3 (1252 ms)
✓ should contain text "Mar 25th" in timezone UTC -4 (1645 ms)
✓ should contain text "Mar 25th" in timezone UTC -5 (1436 ms)
✓ should contain text "Mar 25th" in timezone UTC -6 (1250 ms)
✓ should contain text "Mar 25th" in timezone UTC -7 (1332 ms)
✓ should contain text "Mar 25th" in timezone UTC -8 (1341 ms)
✓ should contain text "Mar 25th" in timezone UTC -9 (1232 ms)
✓ should contain text "Mar 25th" in timezone UTC -10 (1554 ms)
✓ should contain text "Mar 25th" in timezone UTC -11 (1239 ms)
Changed port
✕ should return TestEvents (19996 ms)
Basic auth
✕ should return TestEvents (20004 ms)
Basic auth by default
✕ should return TestEvents (20001 ms)
Basic auth backward compatibility configuration: DEPRECATED
✕ should return TestEvents (20001 ms)
Fail Basic auth
✓ should show Unauthorized error (1205 ms)The test Setup: I'm running node For this test I updated |
|
Now it's getting really strange: Running with node |
dependabot
bot
force-pushed
the
dependabot/npm_and_yarn/develop/node-ical-0.17.0
branch
from
ddd7583 to
4f39ffd
Compare
Bumps [node-ical](https://github.com/jens-maus/node-ical) from 0.16.1 to 0.17.0. - [Commits](https://github.com/jens-maus/node-ical/commits/0.17.0) --- updated-dependencies: - dependency-name: node-ical dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
dependabot
bot
force-pushed
the
dependabot/npm_and_yarn/develop/node-ical-0.17.0
branch
from
4f39ffd to
60840ad
Compare
|
tested with ok for me |
|
@dependabot update |
|
Superseded by #3308. |
dependabot
bot
deleted the
dependabot/npm_and_yarn/develop/node-ical-0.17.0
branch
can confirm it works now, maybe because of new |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps node-ical from 0.16.1 to 0.17.0.
Commits
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)