From fa6a7521b4ad4127fc3dba0403824f660e81de6b Mon Sep 17 00:00:00 2001 From: Karsten Hassel Date: Tue, 24 Sep 2024 22:09:28 +0200 Subject: [PATCH] add tests for minimal node version (currently v20.9.0) (#3556) Beside testing against node version `v20.x` and `v22.x` we should also test against the minimal node version, currently `v20.9.0`. This is for seeing changes in dependencies which needs higher node version as with the July-24-release, where we wrote `node >=20` but shipped an `eslint` version which required `node>=20.9.0`. --- .github/workflows/automated-tests.yaml | 2 +- .github/workflows/electron-rebuild.yaml | 2 +- CHANGELOG.md | 3 ++- 3 files changed, 4 insertions(+), 3 deletions(-) diff --git a/.github/workflows/automated-tests.yaml b/.github/workflows/automated-tests.yaml index 9ac92f216a..e48acd9bcc 100644 --- a/.github/workflows/automated-tests.yaml +++ b/.github/workflows/automated-tests.yaml @@ -18,7 +18,7 @@ jobs: timeout-minutes: 30 strategy: matrix: - node-version: [20.x, 22.x] + node-version: [20.9.0, 20.x, 22.x] steps: - name: "Checkout code" uses: actions/checkout@v4 diff --git a/.github/workflows/electron-rebuild.yaml b/.github/workflows/electron-rebuild.yaml index f9cc50957f..2d22fcedb0 100644 --- a/.github/workflows/electron-rebuild.yaml +++ b/.github/workflows/electron-rebuild.yaml @@ -8,7 +8,7 @@ jobs: runs-on: ubuntu-latest strategy: matrix: - node-version: [20.x, 22.x] + node-version: [20.9.0, 20.x, 22.x] steps: - name: Checkout code uses: actions/checkout@v4 diff --git a/CHANGELOG.md b/CHANGELOG.md index f29a4fd9d4..fc3360bd42 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -17,6 +17,7 @@ _This release is scheduled to be released on 2024-10-01._ - [core] removed `config.paths.vendor` (could not work because `vendor` is hardcoded in `index.html`), renamed `config.paths.modules` to `config.foreignModulesDir`, added variable `MM_CUSTOMCSS_FILE` which - if set - overrides `config.customCss`, added variable `MM_MODULES_DIR` which - if set - overrides `config.foreignModulesDir`, added test for `MM_MODULES_DIR` (#3530) - [core] elements are now removed from `index.html` when loading script or stylesheet files fails - [core] Added `MODULE_DOM_UPDATED` notification each time the DOM is re-rendered via `updateDom` (#3534) +- [tests] added minimal needed node version to tests (currently v20.9.0) to avoid releases with wrong node version info ### Removed @@ -44,7 +45,7 @@ _This release is scheduled to be released on 2024-10-01._ Thanks to: @btoconnor, @bugsounet, @JasonStieber, @khassel, @kleinmantara and @WallysWellies. -> ⚠️ This release needs nodejs version >= v20 +> ⚠️ This release needs nodejs version >= v20.9.0 ### Added