From 291ae8546cb5ec54162135bd8bcaad2cef1a06f9 Mon Sep 17 00:00:00 2001 From: Kristjan ESPERANTO <35647502+KristjanESPERANTO@users.noreply.github.com> Date: Sat, 7 Dec 2024 08:17:04 +0100 Subject: [PATCH] Handle "module is not defined" in e2e tests (#3647) Even in successful tests, there are many module not defined` error entries. Like this: https://github.com/MagicMirrorOrg/MagicMirror/actions/runs/12199106844/job/34032254241#step:5:353 I think we can suppress them. --- CHANGELOG.md | 5 +++-- tests/e2e/helpers/mock-console.js | 1 + 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 9cdc31ec37..40e3802fa1 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -24,7 +24,7 @@ _This release is scheduled to be released on 2025-01-01._ ### Removed -- [tests] Removed node-pty and drivelist from rebuilded test (#3575) +- [tests] Remove `node-pty` and `drivelist` from rebuilded test (#3575) - [deps] Remove `@eslint/js` dependency. Already installed with `eslint` in deep (#3636) ### Updated @@ -43,7 +43,8 @@ _This release is scheduled to be released on 2025-01-01._ - [tests] Fix test cases with hard coded Date.now (#3597) - [core] Fix missing `basePath` where `location.host` is used (#3613) - [compliments] croner library changed filenames used in latest version (#3624) -- [linter] Fix ESLint ignore pattern which caused that default modules not to be linted. (#3632). +- [linter] Fix ESLint ignore pattern which caused that default modules not to be linted (#3632) +- [tests] Suppress "module is not defined" in e2e tests ## [2.29.0] - 2024-10-01 diff --git a/tests/e2e/helpers/mock-console.js b/tests/e2e/helpers/mock-console.js index c593b7062e..b903b7ac51 100644 --- a/tests/e2e/helpers/mock-console.js +++ b/tests/e2e/helpers/mock-console.js @@ -8,6 +8,7 @@ const mockError = (err) => { || err.includes("ECONNRESET") || err.includes("socket hang up") || err.includes("exports is not defined") + || err.includes("module is not defined") || err.includes("write EPIPE") || err.includes("AggregateError") || err.includes("ERR_SOCKET_CONNECTION_TIMEOUT")