Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avatar API Not Working #22

Open
Saachi26 opened this issue Oct 6, 2024 · 15 comments
Open

Avatar API Not Working #22

Saachi26 opened this issue Oct 6, 2024 · 15 comments
Assignees

Comments

@Saachi26
Copy link
Collaborator

Saachi26 commented Oct 6, 2024

The Avatar API, which should provide a new profile picture for each user, is not functioning correctly. The avatars are either missing or not rendering as expected.
Screenshot from 2024-10-06 22-50-17

Expected Behavior
The API should generate and display a unique profile picture for each user in the room.
Tasks
Fix the integration with the Avatar API.
Ensure avatars are rendered correctly for all users.

@Saachi26 Saachi26 added the bug Something isn't working label Oct 6, 2024
@MadhavKrishanGoswami MadhavKrishanGoswami added good first issue Good for newcomers and removed good first issue Good for newcomers labels Oct 6, 2024
@pushkardev123
Copy link

Assign this to me, i'll look into it.

@MadhavKrishanGoswami
Copy link
Owner

go ahead @pushkardev123

@pushkardev123
Copy link

Hey im doing this under hacktoberfest and gssoc24 extd. Please add the respective tags

@pushkardev123
Copy link

where exactly is this avatar to be shown, coz i think i got the problem but in development server, there's no avatar icon being shown anywhere, may i know where it is placed exactly?

@Saachi26
Copy link
Collaborator Author

Currently we are using react-nice-avatar library. https://www.npmjs.com/package/react-nice-avatar
The avatars should be displayed next to each user's name in the people component.
Please check if the API is returning the correct data and ensure the avatar component is properly integrated.
Feel free to suggest another library if you think it might work better! Let me know if you need more information.

@pushkardev123
Copy link

okay sure, sorry i was busy for a while , ill look right into it.

@pushkardev123
Copy link

i think the main problem might be with the config , we can memoise it to be generated only once while rendering, can you please clarify the people component i cant find its position

@MadhavKrishanGoswami
Copy link
Owner

I think you're right about the config, and memoizing it sounds like a good approach. However, I’m a bit confused about what you mean by the "people component" and its position. Could you clarify what you're referring to so I can better understand?

@pushkardev123
Copy link

actually the showpeopleicon is set to false i think, i couldnt find the peoples icon, i have force set it to true as of now, lemme know if there was something else assosciated with this, currently checked the genConfig the avatar is generated correctly , but is not still displayed i think there's some css interferring with the display of the avatar, looking into it currently, till then please do clarify on this people's section

@MadhavKrishanGoswami
Copy link
Owner

The buttons to control the visibility of the people icon are located in apps/web/src/components/MountComponents/MountComponents.jsx. These buttons manage the visibility of that component, so you might want to check there to ensure everything is properly configured.

Let me know if that helps!

@pushkardev123
Copy link

i checked on with the code, and found out there's some problem with the module itself, i tried a few other modules, such as boring avatars and dicebear avatars, i found out they can do the current desired implementation but the avatar styles will be different, so shall i proceed with these modules? coz i really cant figure out what's being the problem with react-nice-avatars . I went through the css and saw no conflicting styles to cause this to not work.
Lemme know if i can proceed with another module, ill post a pull request then

@MadhavKrishanGoswami
Copy link
Owner

Thank you for the update! If you’re encountering issues with react-nice-avatars, please feel free to proceed with Boring Avatars or Dicebear Avatars. I appreciate your efforts and look forward to seeing your pull request!

@pushkardev123
Copy link

I've opened a pr request, please do review it.

@BlossomBreeze25
Copy link

please assign this to me , I want to do this .

@MadhavKrishanGoswami
Copy link
Owner

Absolutely @BlossomBreeze25 , feel free to take a look at the PR from @pushkardev123 for reference. Let me know if you need any help or have any questions! 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants