feat: add php version param for quality tools

Author: serhiidonii

.github/workflows/symfony-php-reusable.yml

@@ -88,6 +88,11 @@ on:
         required: false
         type: string
         default: 'coverage.xml'
+      phpcov-version:
+        description: 'phpcov PHAR version to download from phar.phpunit.de (e.g. 8.2 -> phpcov-8.2.phar)'
+        required: false
+        type: string
+        default: '8.2'
       phpstan-level:
         description: 'PHPStan level (0-9 or max)'
         required: false
@@ -476,17 +481,48 @@ jobs:
               combinations.append(include_item)
 
           # Filter out excluded combinations
+          def _normalize_version(val: str):
+              """
+              Normalize versions so that values with trailing .* behave as a prefix filter.
+              Examples:
+                rule:  "7.3.*" matches combo values "7.3", "7.3.*", "7.3.x", etc. (prefix "7.3")
+                rule:  "7.3"    requires exact match "7.3" (no wildcard semantics)
+              """
+              return val[:-2] if isinstance(val, str) and val.endswith('.*') else val
+
+          def _matches(rule_val, combo_val):
+              # Exact match when rule has no wildcard
+              if not (isinstance(rule_val, str) and rule_val.endswith('.*')):
+                  return combo_val == rule_val
+
+              # Wildcard/prefix match when rule ends with .* (treat as startswith of the prefix)
+              prefix = _normalize_version(rule_val)
+
+              if not isinstance(combo_val, str):
+                  return False
+
+              # Also normalize combo like "7.3.*" to its prefix for matching consistency
+              combo_norm = _normalize_version(combo_val)
+              return str(combo_norm).startswith(str(prefix))
+
           def should_exclude(combo, exclude_rules):
               for rule in exclude_rules:
-                  if all(combo.get(k) == v for k, v in rule.items()):
+                  # All keys in rule must match the combo using wildcard-aware semantics
+                  if all(_matches(v, combo.get(k)) for k, v in rule.items()):
                       return True
               return False
 
-          final_combinations = [c for c in combinations if not should_exclude(c, matrix_exclude)]
+          excluded = []
+          final_combinations = []
+          for c in combinations:
+              if should_exclude(c, matrix_exclude):
+                  excluded.append(c)
+              else:
+                  final_combinations.append(c)
 
           # Output as JSON
           matrix_json = json.dumps({'include': final_combinations})
-          print(f"Generated {len(final_combinations)} test combinations")
+          print(f"Generated {len(final_combinations)} test combinations (excluded {len(excluded)})")
 
           # Write to GITHUB_OUTPUT
           import os
@@ -598,14 +634,19 @@ jobs:
 
       - name: Install dependencies
         working-directory: ${{ inputs['working-directory'] }}
+        env:
+          # Pass detected Symfony version to Composer/Symfony Flex, if any
+          SYMFONY_REQUIRE: ${{ steps.apply-constraints.outputs.symfony_version }}
         run: |
-          echo "Requested constraints: ${{ steps.apply-constraints.outputs.composer_packages }}"
-          if [ "${{ matrix.dependencies }}" = "lowest" ]; then
-            echo "Installing lowest compatible dependencies..."
-            composer update --prefer-lowest --prefer-stable --no-interaction --no-progress
+          # Make sure Flex is allowed/available (if not already in your workflow)
+          composer global config --no-plugins allow-plugins.symfony/flex true
+          composer global require --no-progress --no-scripts --no-plugins symfony/flex
+          if [ -n "${SYMFONY_REQUIRE}" ]; then
+            echo "Using Symfony constraint: ${SYMFONY_REQUIRE}"
+            composer update --prefer-dist --no-progress --no-interaction          
           else
-            echo "Installing highest (locked) dependencies..."
-            composer update --no-interaction --no-progress --prefer-dist
+            echo "No SYMFONY_REQUIRE set, using lock file"
+            composer install --prefer-dist --no-progress --no-interaction
           fi
 
       - name: Run PHPUnit
@@ -661,11 +702,19 @@ jobs:
           php-version: ${{ inputs['php-version-quality-tools'] }}
           coverage: none
 
-      - name: Install phpcov
+      - name: Install coverage tools (phpcov PHAR + phpunit-coverage-check)
         run: |
+          set -e
+          # Download phpcov PHAR for requested version
+          PHPCOV_VERSION="${{ inputs['phpcov-version'] }}"
+          PHPCOV_URL="https://phar.phpunit.de/phpcov-${PHPCOV_VERSION}.phar"
+          echo "Downloading phpcov from ${PHPCOV_URL}"
+          wget -q -O phpcov.phar "$PHPCOV_URL"
+          chmod +x phpcov.phar
+
+          # Install phpunit-coverage-check globally via Composer
           composer global require --no-interaction --no-progress \
-            phpcov/phpcov:^8 \
-            rregeer/phpunit-coverage-check:^1.0
+            rregeer/phpunit-coverage-check:*
           # Add Composer global bin to PATH for both Composer 1 and 2 locations
           echo "$HOME/.composer/vendor/bin" >> $GITHUB_PATH
           echo "$HOME/.config/composer/vendor/bin" >> $GITHUB_PATH
@@ -702,7 +751,7 @@ jobs:
 
           # Try merging with phpcov; if it fails, we will fallback later
           set +e
-          phpcov merge --clover merged-coverage.xml "${COVERAGE_DIRS[@]}"
+          php phpcov.phar merge --clover merged-coverage.xml "${COVERAGE_DIRS[@]}"
           EXIT_CODE=$?
           set -e
 
@@ -715,7 +764,7 @@ jobs:
           echo "phpcov merge succeeded"
           echo "merged=true" >> $GITHUB_OUTPUT
 
-      - name: Parse coverage and validate threshold (phpunit-coverage-check)
+      - name: Parse coverage and validate threshold (coverage-check)
         id: coverage
         env:
           COVERAGE_THRESHOLD: ${{ inputs['coverage-threshold'] }}
@@ -743,16 +792,16 @@ jobs:
             exit 0
           fi
 
-          # Run phpunit-coverage-check. If multiple files, record minimum coverage and mark failure if any fail.
+          # Run coverage-check (from rregeer/phpunit-coverage-check). If multiple files, record minimum coverage and mark failure if any fail.
           OVERALL_STATUS=success
           MIN_COVERAGE=""
           for FILE in "${TARGETS[@]}"; do
             set +e
-            phpunit-coverage-check --min="${COVERAGE_THRESHOLD}" "$FILE" | tee coverage_check_output.txt
+            coverage-check "$FILE" "${COVERAGE_THRESHOLD}" | tee coverage_check_output.txt
             EXIT_CODE=$?
             set -e
-            # Extract percentage like 85.23 from the tool output (last occurrence)
-            PCT=$(sed -nE 's/.*([0-9]+\.[0-9]+)%.*$/\1/p' coverage_check_output.txt | tail -n1)
+            # Extract the current coverage percentage (first percentage in output)
+            PCT=$(grep -Eo '([0-9]+(\.[0-9]+)?)%' coverage_check_output.txt | head -n1 | tr -d '%')
             if [ -z "$PCT" ]; then
               # Fallback: try to read line-rate from Clover and convert to percent
               LR=$(grep -o 'line-rate="[0-9.]*"' "$FILE" | head -1 | sed -E 's/.*="([0-9.]+)"/\1/')
@@ -782,8 +831,8 @@ jobs:
             <!-- coverage-validation-report -->
             ## 📊 Code Coverage Report
             ${{ steps.coverage.outputs.status == 'success'
-                && format('✅Coverage: {0}% (min {1}%) — OK', steps.coverage.outputs.coverage, inputs['coverage-threshold'])
-                || format('❌Coverage: {0}% (min {1}%) — NOT OK', steps.coverage.outputs.coverage, inputs['coverage-threshold'])
+                && format('✅ Coverage: {0}% (min {1}%) — OK', steps.coverage.outputs.coverage, inputs['coverage-threshold'])
+                || format('❌ Coverage: {0}% (min {1}%) — NOT OK', steps.coverage.outputs.coverage, inputs['coverage-threshold'])
             }}
 
             ---

docs/workflows/symfony-php-reusable.md

@@ -17,6 +17,7 @@ The workflow now features **fully dynamic matrix generation** with Cartesian pro
 - 🚫 **matrix-exclude**: Filter incompatible combinations
 - 🐛 **Xdebug Auto-Configuration**: Automatically adds xdebug extension when coverage enabled
 - 🔧 **Quality Tools PHP Version**: Configure separate PHP version for static analysis tools
+- 🧩 **Symfony Minor Detection**: The workflow detects the Symfony version from your matrix and exposes it to Composer via `SYMFONY_REQUIRE` during dependency installation (no change to install commands required)
 
 **Example Matrix Output:**
 ```text
@@ -69,11 +70,12 @@ This workflow automates the complete CI process for Symfony PHP projects:
 | `enable-coverage-check` | boolean | ❌ | `false` | Enable coverage validation and PR comments |
 | `coverage-threshold` | number | ❌ | `70` | Minimum code coverage percentage required (0-100) |
 | `coverage-file` | string | ❌ | `coverage.xml` | Coverage report file name (Clover XML). Used for PHPUnit generation, Codecov upload, and coverage validation. |
+| `phpcov-version` | string | ❌ | `8.2` | Version of phpcov PHAR to download from phar.phpunit.de (e.g., `8.2` downloads `phpcov-8.2.phar`). |
 | `phpstan-level` | string | ❌ | `max` | PHPStan level (0-9 or max) |
 | `working-directory` | string | ❌ | `.` | Working directory for the project |
 | `php-extensions` | string | ❌ | `mbstring, json` | Additional PHP extensions to install. xdebug auto-added when coverage enabled. |
 | `php-version-quality-tools` | string | ❌ | `8.3` | PHP version to use for quality tools (PHPStan, PHPCS, Rector, Infection, etc.) |
-| `matrix-exclude` | string (JSON array) | ❌ | Default Symfony 7.x exclusions | Matrix combinations to exclude. Supports any package from `versions-matrix`. |
+| `matrix-exclude` | string (JSON array) | ❌ | Default Symfony 7.x exclusions | Matrix combinations to exclude. Supports any package from `versions-matrix`. Values ending with `.*` act as wildcards/prefixes (e.g., `"7.3.*"` matches `"7.3"` and `"7.3.*"`), while values without `.*` require exact match. |
 | `infection-min-msi` | number | ❌ | `80` | Minimum Mutation Score Indicator (MSI) for Infection |
 | `infection-min-covered-msi` | number | ❌ | `90` | Minimum Covered Code MSI for Infection |
 | `phpstan-config` | string | ❌ | `''` | Path to PHPStan configuration file (default: phpstan.neon.dist or phpstan.neon) |
@@ -716,7 +718,7 @@ Generated Combinations:
 - **Symfony 7.3+**: Requires PHP 8.2+
 
 #### Dynamic Package Constraint Application
-The workflow automatically applies version constraints for **all packages** in versions-matrix:
+The workflow automatically applies version constraints for **all packages** in versions-matrix and detects Symfony minor for Flex:
 
 **Process:**
 1. **Parse Matrix**: Each test job receives matrix combination (e.g., `{"php": "8.3", "symfony/cache": "7.0.*", "symfony/config": "6.4.*"}`)
@@ -726,6 +728,7 @@ The workflow automatically applies version constraints for **all packages** in v
    - Apply constraint: `composer require "{package}:{version}" --no-update --no-interaction`
    - Detect Symfony version and set Composer extra: If the package is `symfony/framework-bundle`, set `composer config extra.symfony.require "{version}"`. If not provided, the workflow will try to infer Symfony version from the first `symfony/*` package in the matrix and set it accordingly.
 4. **Install Dependencies**:
+   - The job exports `SYMFONY_REQUIRE` environment variable for this step using the detected Symfony version. This lets Symfony Flex align all `symfony/*` packages to the same minor automatically.
    - Highest: `composer update --no-interaction --no-progress --prefer-dist`
    - Lowest: `composer update --prefer-lowest --prefer-stable --no-interaction --no-progress`
 
@@ -754,6 +757,7 @@ versions-matrix: |
 # - symfony/console:7.0.*
 # - doctrine/orm:3.0.*
 # extra.symfony.require: 7.0.*
+# SYMFONY_REQUIRE env (Install dependencies step): 7.0.*
 ```
 
 **Key Feature**: NO hardcoded package names! The workflow dynamically detects and applies constraints for any packages in the matrix.
@@ -836,6 +840,16 @@ with:
     ]
 ```
 
+#### Exclusion Matching Semantics
+
+- Wildcard match: A rule value ending with `.*` is treated as a prefix. For example:
+  - `{ "symfony/framework-bundle": "7.3.*" }` will match matrix values `"7.3"`, `"7.3.*"`, `"7.3.x"`, etc.
+- Exact match: A rule value without `.*` must equal the matrix value exactly. For example:
+  - `{ "php": "8.2" }` matches only `"8.2"`, not `"8.2.1"`.
+- Mixed rules: All keys in a rule must match (AND behavior). This lets you target precise combinations like `{ "php": "8.2", "symfony/framework-bundle": "7.2.*" }`.
+
+This behavior ensures that exclusions like `"7.2.*"` and `"7.3.*"` properly skip jobs even if your `versions-matrix` lists values as `"7.2"` or `"7.3"` without the trailing `.*`.
+
 **Disable All Exclusions:**
 ```yaml
 with:
@@ -952,9 +966,9 @@ coverage-threshold: 80           # Minimum coverage % (default: 70)
 1. Unit tests with coverage generate Clover XML (`coverage.xml` by default) and raw coverage (`coverage.cov`).
 2. Coverage files are uploaded as artifacts (one artifact per matrix job).
 3. `coverage-validation` job:
-   - Installs two tools globally: `phpcov/phpcov` and `rregeer/phpunit-coverage-check`
+   - Downloads `phpcov` as a PHAR from phar.phpunit.de using `phpcov-version` input and installs `rregeer/phpunit-coverage-check` globally
    - Downloads all coverage artifacts to `coverage-artifacts/`
-   - Attempts to merge raw coverage with `phpcov merge --clover merged-coverage.xml <dirs>`
+   - Attempts to merge raw coverage with `php phpcov.phar merge --clover merged-coverage.xml <dirs>`
    - Runs `phpunit-coverage-check --min=<threshold>` on the merged Clover; if no merged file exists, checks the single Clover file; if multiple Clovers exist, each is checked and the result fails if any are below the threshold
 4. Posts or updates a PR comment with a simple OK/NOT OK message and the current coverage value
 5. Fails job if coverage < threshold
@@ -968,7 +982,7 @@ Coverage: 85.50% (min 80%) — OK
 - Must run on `pull_request` event (validation only runs on PRs)
 - At least one matrix combination must have `"coverage": "xdebug"`
 - Requires `pull-requests: write` permission (auto-granted in most workflows)
-- `phpcov/phpcov` and `rregeer/phpunit-coverage-check` are installed automatically in the coverage validation job
+- `phpcov` is downloaded as a PHAR (`phpcov-<version>.phar`) and `rregeer/phpunit-coverage-check` is installed automatically in the coverage validation job
 
 **Edge Cases:**
 - **No coverage artifacts**: Job succeeds with status "no-coverage" (no comment posted)