Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build failed in Xcode 9.3 #954

Closed
FranklinYu opened this issue Apr 3, 2018 · 4 comments
Closed

Build failed in Xcode 9.3 #954

FranklinYu opened this issue Apr 3, 2018 · 4 comments

Comments

@FranklinYu
Copy link
Member

See Bertrand/handlebars-objc#20. The repository is pretty much dead; we may want to host our own.

@uranusjr
Copy link
Member

uranusjr commented Apr 6, 2018

Forked.

@uranusjr
Copy link
Member

uranusjr commented Apr 6, 2018

Probably can use some more work to fix those pesky warnings as well.

@uranusjr uranusjr removed the upstream label Apr 6, 2018
@FranklinYu
Copy link
Member Author

I thought that inhibit_all_warnings! is enough, but it turned out not to be. I’m wondering whether this is a bug of CocoaPods, and we should simply report this to CocoaPods.

If we were going to fix those warning ourselves, then we should probably enable issue in MacDownApp/handlebars-objc.

@uranusjr
Copy link
Member

uranusjr commented Apr 6, 2018

Good idea. inhibit_all_warnings! does work for other projects though, so there might be something special with those warnings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants