Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Opening large files causes editor to white screen #788

Open
MaffooBristol opened this issue Apr 13, 2017 · 10 comments
Open

Opening large files causes editor to white screen #788

MaffooBristol opened this issue Apr 13, 2017 · 10 comments
Labels

Comments

@MaffooBristol
Copy link

It's not the most easily reproducible issue, but it may have something to do with scrolling.

If I create a new file, everything works okay. Put in a few lines of text, save, close, open the file, everything's fine.

Try the same thing but with a file with many new lines (I experimented with lipsum and the like, and the word count seems to not affect it as much as the vertical length). Save, close, open the file- now the preview pane works fine as always, but the editor comes up as purely a white screen (or the background colour of the theme) and doesn't show text, allow user input, etc.

I recently upgraded by a few versions as I hadn't used Macdown for a while. Definitely used to work, definitely doesn't now. I'm on Mavericks.

Cheers

Unsaved:
image

Saved and reopened:
image

Macdown version:
image

Mac version:
image

@MaffooBristol
Copy link
Author

Ps. Just tried Version 0.6.5d56 (842), still same bug.

@MaffooBristol
Copy link
Author

Just tried rolling back through the releases. Appears this was introduced quite a long time ago...

  • 0.4.4.1 and below - Works fine
  • 0.4.5 - Doesn't open at all
  • 0.4.5.1 and later - Bug as above

@MaffooBristol
Copy link
Author

Seems it could be a duplicate of #401, which still hasn't been resolved. I do admittedly have my editor on the right, so I'll try and experiment with turning that off and using a later build...

@MaffooBristol
Copy link
Author

What the helllllll... just re-downloaded 0.6.4 from the releases page and it's miraculously started working 😖

@uranusjr
Copy link
Member

My wild guess is this probably has something to do with caching inside the web view. 0.4.5 upgraded Prism and likely invalidated the cache. The cache kicked in when you ran 0.6.4 for a second time, and the everything works.

The above is just speculation, it’s possible this is totally not what happened, but the web view rendering blocking the UI thread is a real problem. It would be best if we can do this in a different process, like what (modern) browsers and Mou do, but I’m not sure what is the best way to do it.

@FranklinYu FranklinYu added the bug label Apr 14, 2017
@niklasberglund
Copy link
Collaborator

I was also thinking WebView issue with memory leak or cache management. Thinking that migrating to WKWebView might solve random web view issues like this one.

@uranusjr
Copy link
Member

Incidentally, switching to WKWebView would bump the requirements to 10.10, thus not solving OP’s problem. Just saying. :p

@FranklinYu
Copy link
Member

FranklinYu commented Apr 14, 2017

@niklasberglund But @MaffooBristol is using Mavericks…

Edit: didn't refresh before comment…

@FranklinYu
Copy link
Member

@MaffooBristol Hi there. Are you still using Mavericks? We plan to drop support for quite some old versions of macOS (#738).

@MaffooBristol
Copy link
Author

@FranklinYu Nope! Feel free to close as desired

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants