Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review package compatibility #16

Open
uranusjr opened this issue Feb 21, 2020 · 5 comments
Open

Review package compatibility #16

uranusjr opened this issue Feb 21, 2020 · 5 comments

Comments

@uranusjr
Copy link
Member

Netlify informs me that a recent build is failing: (full log in Gist)

3:03:39 PM: Traceback (most recent call last):
3:03:39 PM:   File "/opt/buildhome/python2.7/bin/invoke", line 10, in <module>
3:03:39 PM:     sys.exit(program.run())
3:03:39 PM:   File "/opt/buildhome/python2.7/local/lib/python2.7/site-packages/invoke/program.py", line 384, in run
3:03:39 PM:     self.execute()
3:03:39 PM:   File "/opt/buildhome/python2.7/local/lib/python2.7/site-packages/invoke/program.py", line 566, in execute
3:03:39 PM: executor.execute(*self.tasks)
3:03:39 PM:   File "/opt/buildhome/python2.7/local/lib/python2.7/site-packages/invoke/executor.py", line 129, in execute
3:03:39 PM:     result = call.task(*args, **call.kwargs)
3:03:39 PM:   File "/opt/buildhome/python2.7/local/lib/python2.7/site-packages/invoke/tasks.py", line 127, in __call__
3:03:39 PM:     result = self.body(*args, **kwargs)
3:03:39 PM:   File "/opt/build/repo/tasks.py", line 119, in build
3:03:39 PM:     lektor_cli_ctx.load_plugins()
3:03:39 PM:   File "/opt/buildhome/python2.7/local/lib/python2.7/site-packages/lektor/cli.py", line 131, in load_plugins
3:03:39 PM:     initialize_plugins(self.get_env())
3:03:39 PM:   File "/opt/buildhome/python2.7/local/lib/python2.7/site-packages/lektor/pluginsystem.py", line 122, in initialize_plugins
3:03:39 PM:     plugins = load_plugins()
3:03:39 PM:   File "/opt/buildhome/python2.7/local/lib/python2.7/site-packages/lektor/pluginsystem.py", line 116, in load_plugins
3:03:39 PM:     rv[ep.name] = ep.load()
3:03:39 PM:   File "/opt/buildhome/python2.7/local/lib/python2.7/site-packages/pkg_resources/__init__.py", line 2434, in load
3:03:39 PM:     return self.resolve()
3:03:39 PM:   File "/opt/buildhome/python2.7/local/lib/python2.7/site-packages/pkg_resources/__init__.py", line 2440, in resolve
3:03:39 PM:     module = __import__(self.module_name, fromlist=['__name__'], level=0)
3:03:39 PM:   File "/opt/build/repo/packages/lektor-atom/lektor_atom.py", line 22, in <module>
3:03:39 PM:     from werkzeug.contrib.atom import AtomFeed
3:03:39 PM: ImportError: No module named contrib.atom

Not sure what the problem is atm.

@FranklinYu
Copy link
Member

I suspect that we didn’t freeze the package version.

@FranklinYu
Copy link
Member

Quote from https://werkzeug.palletsprojects.com/en/0.16.x/contrib/atom/

Deprecated since version 0.15: This will be removed in version 1.0. Use a dedicated feed library instead.

Would you recommend fixing version at < 1.0 or finding an atom library?

@uranusjr
Copy link
Member Author

Yeah, sounds good to me.

@FranklinYu
Copy link
Member

FranklinYu commented Feb 22, 2020

That was a choice between two… I assume you mean fixing version instead of finding an atom library?

Digging the history: the package lektor-atom was vendored probably because of lektor/lektor-atom#9, which has been fixed. If they also merge lektor/lektor-atom#25 and make a release with that change, maybe we can use that directly.

@uranusjr
Copy link
Member Author

Oh I totally missed the second part LOL, sorry.

I was saying that it’s a good idea to simply fix the version. We are not using much of werkzeug at all anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants