437 fixbug correction front ulam listes des missions #443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage Report for frontend
File Coverage
|
||||||||||||||||||||||||||||||||||||||
|
xtiannyeto
requested changes
Nov 28, 2024
| @@ -51,11 +52,15 @@ const formatShortDate = (date: DateTypes): string => formatDate(date, SHORT_DAY_ | |||
|
|
|||
| const formatTime = (date: DateTypes): string => formatDate(date, SHORT_TIME, EMPTY_SHORT_TIME) | |||
|
|
|||
| const formatDateFormMissionUlamName = (date: DateTypes): string => | |||
| formatDate(date, MISSION_ULAM_NAME_FORMAT, EMPTY_FRENCH_DAY_MONTH_YEAR) | |||
There was a problem hiding this comment.
il existe un hook useDate dans V2, c'est ce qu'il faut utiliser.
Il ne doit pas avoir de dépendance entre V2 et V1
| import { | ||
| formatDateForFrenchHumans, | ||
| formatDateFormMissionUlamName | ||
| } from '@common/utils/dates-for-humans.ts' | ||
| import MissionCompletenessForStatsTag from './mission-completeness-for-stats-tag.tsx'; | ||
| import MissionStatusTag from './mission-status-tag.tsx'; | ||
| import MissionOpenByTag from '@features/pam/mission/components/elements/mission-open-by-tag.tsx'; |
There was a problem hiding this comment.
Pareil, pas de dépendances entre v1 et V2, si le component existe pas coté v2, le recréer, dans la bonne arborescence v2/common/components/(ui/elements/layout)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.