From a7cef043b9dfd4dcff65f5a7a04410600d197a28 Mon Sep 17 00:00:00 2001
From: Claire Dagan <clairedagan@gmail.com>
Date: Mon, 18 Sep 2023 11:04:59 +0200
Subject: [PATCH] [Mission] surveillance zone is now mandatory when close
 mission

---
 .../missions/MissionForm/Schemas/Surveillance.ts    | 13 ++++++++++++-
 frontend/src/features/missions/MultiZonePicker.tsx  |  2 +-
 2 files changed, 13 insertions(+), 2 deletions(-)

diff --git a/frontend/src/features/missions/MissionForm/Schemas/Surveillance.ts b/frontend/src/features/missions/MissionForm/Schemas/Surveillance.ts
index e7d66011e0..293e1cd7ce 100644
--- a/frontend/src/features/missions/MissionForm/Schemas/Surveillance.ts
+++ b/frontend/src/features/missions/MissionForm/Schemas/Surveillance.ts
@@ -2,6 +2,9 @@ import * as Yup from 'yup'
 
 import { ThemeSchema } from './Theme'
 import { ActionTypeEnum, EnvActionSurveillance } from '../../../../domain/entities/missions'
+import { REACT_APP_CYPRESS_TEST } from '../../../../env'
+
+const shouldUseAlternateValidationInTestEnvironment = process.env.NODE_ENV === 'development' || REACT_APP_CYPRESS_TEST
 
 export const getNewEnvActionSurveillanceSchema = (ctx: any): Yup.SchemaOf<EnvActionSurveillance> =>
   Yup.object()
@@ -84,7 +87,15 @@ export const getClosedEnvActionSurveillanceSchema = (ctx: any): Yup.SchemaOf<Env
           }
         }),
       actionType: Yup.mixed().oneOf([ActionTypeEnum.SURVEILLANCE]),
-      geom: Yup.array().ensure(),
+      geom: Yup.object().when('coverMissionZone', {
+        is: true,
+        otherwise: () =>
+          shouldUseAlternateValidationInTestEnvironment
+            ? Yup.object().nullable()
+            : Yup.array().ensure().min(1, 'Requis'),
+        then: () => Yup.object().nullable()
+      }),
+
       id: Yup.string().required(),
       themes: Yup.array().of(ThemeSchema).ensure().required()
     })
diff --git a/frontend/src/features/missions/MultiZonePicker.tsx b/frontend/src/features/missions/MultiZonePicker.tsx
index b5c435990d..eee2e8f399 100644
--- a/frontend/src/features/missions/MultiZonePicker.tsx
+++ b/frontend/src/features/missions/MultiZonePicker.tsx
@@ -98,7 +98,7 @@ export function MultiZonePicker({
         {addButtonLabel}
       </Button>
 
-      {!!meta.error && <ErrorMessage>Veuillez définir une zone de mission</ErrorMessage>}
+      {!!meta.error && <ErrorMessage>Veuillez définir une zone</ErrorMessage>}
 
       <>
         {polygons.map((polygonCoordinates, index) => (