chore: visibility on test

Author: Fabien

dossierfacile-process-file/src/test/java/fr/dossierfacile/process/file/service/documentrules/GuaranteeProviderRulesValidationServiceTest.java

@@ -64,7 +64,7 @@ Document buildGuaranteeProviderFile() throws JsonProcessingException {
 
 
     @Test
-    public void document_full_test() throws Exception {
+    void document_full_test() throws Exception {
         Document document = buildGuaranteeProviderFile();
         ((GuaranteeProviderFile) document.getFiles().get(0).getParsedFileAnalysis().getParsedFile())
                 .setValidityDate(LocalDate.now().plusMonths(1).format(DateTimeFormatter.ofPattern("dd/MM/yyyy")));
@@ -78,7 +78,7 @@ public void document_full_test() throws Exception {
     }
 
     @Test
-    public void document_expired() throws Exception {
+    void document_expired() throws Exception {
         Document document = buildGuaranteeProviderFile();
         ((GuaranteeProviderFile) document.getFiles().get(0).getParsedFileAnalysis().getParsedFile())
                 .setValidityDate(LocalDate.now().minusDays(1).format(DateTimeFormatter.ofPattern("dd/MM/yyyy")));
@@ -94,7 +94,7 @@ public void document_expired() throws Exception {
     }
 
     @Test
-    public void document_wrong_firstname() throws Exception {
+    void document_wrong_firstname() throws Exception {
         Document document = buildGuaranteeProviderFile();
         document.getTenant().setFirstName("Michel");
         ((GuaranteeProviderFile) document.getFiles().get(0).getParsedFileAnalysis().getParsedFile())

dossierfacile-process-file/src/test/java/fr/dossierfacile/process/file/service/documentrules/IncomeTaxRulesValidationServiceTest.java

@@ -59,7 +59,7 @@ private Document buildValidTaxDocument() throws Exception {
     }
 
     @Test
-    public void document_full_test() throws Exception {
+    void document_full_test() throws Exception {
         Document document = buildValidTaxDocument();
         DocumentAnalysisReport report = DocumentAnalysisReport.builder()
                 .document(document)
@@ -71,7 +71,7 @@ public void document_full_test() throws Exception {
     }
 
     @Test
-    public void document_ok_with_two_file() throws Exception {
+    void document_ok_with_two_file() throws Exception {
         Document document = buildValidTaxDocument();
         document.getFiles().add(buildValidDfFileWithYear(LocalDate.now().minusMonths(31).getYear()));
         DocumentAnalysisReport report = DocumentAnalysisReport.builder()
@@ -84,7 +84,7 @@ public void document_ok_with_two_file() throws Exception {
     }
 
     @Test
-    public void document_full_test_with_preferredname() throws Exception {
+    void document_full_test_with_preferredname() throws Exception {
         Document document = buildValidTaxDocument();
         document.getTenant().setPreferredName(document.getTenant().getLastName());
         document.getTenant().setLastName("AUTRE");
@@ -97,8 +97,9 @@ public void document_full_test_with_preferredname() throws Exception {
 
         Assertions.assertThat(report.getAnalysisStatus()).isEqualTo(DocumentAnalysisStatus.CHECKED);
     }
+
     @Test
-    public void document_full_test_wrong_firstname() throws Exception {
+    void document_full_test_wrong_firstname() throws Exception {
         Document document = buildValidTaxDocument();
         document.getTenant().setFirstName("Joseph");
         DocumentAnalysisReport report = DocumentAnalysisReport.builder()

dossierfacile-process-file/src/test/java/fr/dossierfacile/process/file/util/PersonNameComparatorTest.java

@@ -5,47 +5,47 @@
 
 class PersonNameComparatorTest {
     @Test
-    public void compare_name_should_be_ok() {
+    void compare_name_should_be_ok() {
         String givenFirstName = "Jean Phillipe";
         String givenLastName = "DE LA MARCHE";
         String fullName = "DE LA MARCHE PICQUET Edouard Jean Phillipe";
         Assertions.assertEquals(true, PersonNameComparator.bearlyEqualsTo(fullName, givenLastName, givenFirstName));
     }
 
     @Test
-    public void compare_name_should_be_ko_particule() {
+    void compare_name_should_be_ko_particule() {
         String givenFirstName = "Jean Phillipe";
         String givenLastName = "DE LA ROSE";
         String fullName = "DE LA MARCHE PICQUET Edouard Jean Phillipe";
         Assertions.assertEquals(false, PersonNameComparator.bearlyEqualsTo(fullName, givenLastName, givenFirstName));
     }
 
     @Test
-    public void compare_name_should_be_ko() {
+    void compare_name_should_be_ko() {
         String givenFirstName = "Jean Phillipe";
         String givenLastName = "DE LA MARCHE";
         String fullName = "PICQUET Edouard Jean Phillipe";
         Assertions.assertEquals(false, PersonNameComparator.bearlyEqualsTo(fullName, givenLastName, givenFirstName));
     }
 
     @Test
-    public void compare_name_should_be_ok2() {
+    void compare_name_should_be_ok2() {
         String givenFirstName = "Jean Phillipe";
         String givenLastName = "MARCHE";
         String fullName = "ROSE-MARCHE Jean";
         Assertions.assertEquals(true, PersonNameComparator.bearlyEqualsTo(fullName, givenLastName, givenFirstName));
     }
 
     @Test
-    public void compare_name_should_be_ok_basc() {
+    void compare_name_should_be_ok_basc() {
         String givenFirstName = "Jean";
         String givenLastName = "MARCHE";
         String fullName = "MARCHE Jean";
         Assertions.assertEquals(true, PersonNameComparator.bearlyEqualsTo(fullName, givenLastName, givenFirstName));
     }
 
     @Test
-    public void compare_name_should_be_nok_reverse() {
+    void compare_name_should_be_nok_reverse() {
         String givenFirstName = "Marche";
         String givenLastName = "Jean";
         String fullName = "MARCHE Jean";