Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unused argument simname in create_sup_file() #21

Open
ohexel opened this issue Nov 26, 2024 · 0 comments
Open

Unused argument simname in create_sup_file() #21

ohexel opened this issue Nov 26, 2024 · 0 comments

Comments

@ohexel
Copy link

ohexel commented Nov 26, 2024

The argument simname in create_sup_file <- function(simfolder, simname) isn't actually used.

Maybe it was supposed to used instead of the hardcoded socsim.sup? See the line sup.fn <- "socsim.sup".
tomthe added a commit that referenced this issue Dec 4, 2024
@tomthe
Merge pull request #22 from ohexel/fix-issue-21
0421ebf 
Make `create_sup_file()` actually use the argument `simname` (fix issue #21)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ohexel