Skip to content

Commit db4571f

Browse files
sshanessysm
authored andcommitted
Fix duplicate process names (commaai#34446)
* test * anything actually use this? * keep it around
1 parent fbed304 commit db4571f

File tree

2 files changed

+5
-2
lines changed

2 files changed

+5
-2
lines changed

system/manager/process_config.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -86,7 +86,7 @@ def and_(*fns):
8686
NativeProcess("ui", "selfdrive/ui", ["./ui"], always_run, watchdog_max_dt=(5 if not PC else None)),
8787
PythonProcess("soundd", "selfdrive.ui.soundd", only_onroad),
8888
PythonProcess("locationd", "selfdrive.locationd.locationd", only_onroad),
89-
NativeProcess("pandad", "selfdrive/pandad", ["./pandad"], always_run, enabled=False),
89+
NativeProcess("_pandad", "selfdrive/pandad", ["./pandad"], always_run, enabled=False),
9090
PythonProcess("calibrationd", "selfdrive.locationd.calibrationd", only_onroad),
9191
PythonProcess("torqued", "selfdrive.locationd.torqued", only_onroad),
9292
PythonProcess("controlsd", "selfdrive.controls.controlsd", and_(not_joystick, iscar)),

system/manager/test/test_manager.py

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
from openpilot.common.params import Params
88
import openpilot.system.manager.manager as manager
99
from openpilot.system.manager.process import ensure_running
10-
from openpilot.system.manager.process_config import managed_processes
10+
from openpilot.system.manager.process_config import managed_processes, procs
1111
from openpilot.system.hardware import HARDWARE
1212

1313
os.environ['FAKEUPLOAD'] = "1"
@@ -31,6 +31,9 @@ def test_manager_prepare(self):
3131
os.environ['PREPAREONLY'] = '1'
3232
manager.main()
3333

34+
def test_duplicate_procs(self):
35+
assert len(procs) == len(managed_processes), "Duplicate process names"
36+
3437
def test_blacklisted_procs(self):
3538
# TODO: ensure there are blacklisted procs until we have a dedicated test
3639
assert len(BLACKLIST_PROCS), "No blacklisted procs to test not_run"

0 commit comments

Comments
 (0)